Open Bug 1250246 Opened 8 years ago Updated 10 months ago

Dispatch alert listener callbacks asynchronously

Categories

(Toolkit :: Alerts Service, defect)

Product:
Toolkit
Component:
Alerts Service
Type:
defect

Tracking

()

People

(Reporter: lina, Unassigned)

References

Details

:karlt pointed out that we're calling some of the alert listener callbacks synchronously. In particular:

* `alertfinished` if we shouldn't show a notification on Windows (https://dxr.mozilla.org/mozilla-central/rev/e1cf617a1f2813b6cd66f460313a61c223406c9b/toolkit/components/alerts/nsAlertsService.cpp#259-264), DND is enabled for XUL alerts (https://dxr.mozilla.org/mozilla-central/rev/e1cf617a1f2813b6cd66f460313a61c223406c9b/toolkit/components/alerts/nsXULAlerts.cpp#95,110-111), or a libnotify alert is closed before it's shown (bug 1227730).

* `alertshown` for libnotify alerts without an image (https://dxr.mozilla.org/mozilla-central/rev/e1cf617a1f2813b6cd66f460313a61c223406c9b/toolkit/system/gnome/nsAlertsIconListener.cpp#216-217,233-234).

Should we consider dispatching these asynchronously?
Severity: normal → S3
Component: Notifications and Alerts → Alerts Service
You need to log in before you can comment on or make changes to this bug.