Closed Bug 1250264 Opened 5 years ago Closed 5 years ago
Extensions have no easy way to override favicon
Currently, the path to favicon.ico is hardcoded in global/header.html.tmpl: <link rel="shortcut icon" href="images/favicon.ico" > This forces installations to override images/favicon.ico instead of having their own favicon in extensions/Foo/web/favicon.ico or to make it point to the one used by the website. An ugly alternative is to have its own copy of header.html.tmpl in extensions/Foo/template/en/default/global/header.html.tmpl to just edit this URL, which is a pretty bad idea. We should make installations life easier and provide a hook to easily set it.
This will trivial to do in a pure-plack world, btw.
favicon_url can be edited thanks to the existing 'start' hook.
Assignee: extensions → LpSolit
Status: NEW → ASSIGNED
Attachment #8722160 - Flags: review?(dkl)
Comment on attachment 8722160 [details] [diff] [review] patch, v1 r=dkl
Attachment #8722160 - Flags: review?(dkl) → review+
Target Milestone: Bugzilla 6.0 → Bugzilla 5.0
To ssh://email@example.com/bugzilla/bugzilla.git b2e1ec0..a8adffb master -> master To ssh://firstname.lastname@example.org/bugzilla/bugzilla.git b33684a..b241244 5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.