Extensions have no easy way to override favicon.ico

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
Extensions
--
minor
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

unspecified
Bugzilla 5.0
Bug Flags:
approval5.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently, the path to favicon.ico is hardcoded in global/header.html.tmpl:

  <link rel="shortcut icon" href="images/favicon.ico" >

This forces installations to override images/favicon.ico instead of having their own favicon in extensions/Foo/web/favicon.ico or to make it point to the one used by the website. An ugly alternative is to have its own copy of header.html.tmpl in extensions/Foo/template/en/default/global/header.html.tmpl to just edit this URL, which is a pretty bad idea. We should make installations life easier and provide a hook to easily set it.
This will trivial to do in a pure-plack world, btw.
(Assignee)

Comment 2

2 years ago
Created attachment 8722160 [details] [diff] [review]
patch, v1

favicon_url can be edited thanks to the existing 'start' hook.
Assignee: extensions → LpSolit
Status: NEW → ASSIGNED
Attachment #8722160 - Flags: review?(dkl)
Comment on attachment 8722160 [details] [diff] [review]
patch, v1

r=dkl
Attachment #8722160 - Flags: review?(dkl) → review+

Updated

2 years ago
Target Milestone: --- → Bugzilla 6.0

Updated

2 years ago
Flags: approval5.0+
Target Milestone: Bugzilla 6.0 → Bugzilla 5.0
(Assignee)

Comment 4

2 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   b2e1ec0..a8adffb  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   b33684a..b241244  5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.