Open Bug 1250285 Opened 4 years ago Updated 3 years ago

visual polish for web notifications favicon support on OS X

Categories

(Toolkit :: Notifications and Alerts, defect)

Unspecified
macOS
defect
Not set

Tracking

()

People

(Reporter: canuckistani, Unassigned)

References

Details

Philipp has some feedback from the results of bug 1224785:

"
I think there are two issues here:
OS X forces (?) the favicon to be the same size as the site-provided image
OS X forces (?) the Firefox/Nightly logo in there as well next to the title
Both of these issues shouldn't exist on Windows, which is good.

On OS X, the ideal solution would be to move the site-provided image to the left (where currently the giant favicon is displayed) and move the favicon to where we currently show the small Nightly logo.

If that's technically not possible, we should revert to the previous state on OS X (again, this shouldn't really influence Windows).
"
Philipp, could you upload a screenshot for the first issue, please? I see (low-res) 16x16 icons for :edwong's test page, Slack, and Gmail, but that's probably because Places scales them down before they're saved (bug 492172, comment 4). I'm guessing icons larger than 16x16 but less than 1 KB will be shown as-is.

The second issue is trickier. We can swap the favicon and content image, though, in that case, Notification Center will show the icon instead of the image. Unfortunately, we can't remove the app icon. I think it's helpful for reassuring users that the notification comes from Firefox, but "via ..." already identifies the sender, and it's inconsistent with XUL.

Given those constraints, should we revert to not showing favicons at all on OS X?
Flags: needinfo?(philipp)
See Also: → 1250288
(In reply to Kit Cambridge [:kitcambridge] from comment #1)
> Philipp, could you upload a screenshot for the first issue, please? I see
> (low-res) 16x16 icons for :edwong's test page, Slack, and Gmail, but that's
> probably because Places scales them down before they're saved (bug 492172,
> comment 4). I'm guessing icons larger than 16x16 but less than 1 KB will be
> shown as-is.
I think we are talking about the same thing :)
Regardless of the reason, we are often showing a 16x16 icon scaled up and that doesn't look good.

> The second issue is trickier. We can swap the favicon and content image,
> though, in that case, Notification Center will show the icon instead of the
> image. Unfortunately, we can't remove the app icon. I think it's helpful for
> reassuring users that the notification comes from Firefox, but "via ..."
> already identifies the sender, and it's inconsistent with XUL.
> 
> Given those constraints, should we revert to not showing favicons at all on
> OS X?
Yes, I think so. OS X seems to put so many constraints on s that we can't do it in a proper way, so let's not do it at all.
Flags: needinfo?(philipp)
It might be time to revisit this soon, now that Places stores hi-res favicons.
You need to log in before you can comment on or make changes to this bug.