1250315 - input type="number" matches :-moz-read-only when it is not read only

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[andrew]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160222004010

Steps to reproduce:

1. Create an input type="number"
2. Add CSS for :-moz-read-only

https://jsfiddle.net/tp0s1nbb/2/


Actual results:

The number input was matched by the :-moz-read-only selector.


Expected results:

The number input should not be matched by the :-moz-read-only selector.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Make <input type=number readonly> match :-moz-read-only and allow context events.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9fdab4887dc

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8722813 [details] [diff] [review]
Make <input type=number readonly> match :-moz-read-only and allow context events.

Review of attachment 8722813 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/EventStateManager.cpp
@@ +1508,5 @@
>      else if (mGestureDownContent->IsHTMLElement()) {
>        nsCOMPtr<nsIFormControl> formCtrl(do_QueryInterface(mGestureDownContent));
>  
>        if (formCtrl) {
> +        allowedToDispatch = formCtrl->IsTextOrNumberControl(false) ||

While you're here can you make this:

  IsTextOrNumberControl(/*aExcludePassword*/ false)

::: dom/html/nsGenericHTMLElement.cpp
@@ +2368,5 @@
>    }
>  
>    // Make the text controls read-write
>    if (!state.HasState(NS_EVENT_STATE_MOZ_READWRITE) &&
> +      IsTextOrNumberControl(false)) {

And here

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a46c9fc47597

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a46c9fc47597