Closed
Bug 1250364
Opened 9 years ago
Closed 9 years ago
e10s makes page loads slow when using "AdBlock for YouTube"
Categories
(Firefox :: Extension Compatibility, defect)
Firefox
Extension Compatibility
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| e10s | + | --- |
People
(Reporter: jrmuizel, Unassigned)
References
Details
Loading http://www.gotransit.com/timetables/en/schedules/schedules_window.aspx?tableid=21&dir=E&corridorname=Milton&parentid=1 is very slow with this add-on installed and e10s turned on.
| Reporter | ||
Updated•9 years ago
|
tracking-e10s:
--- → ?
Updated•9 years ago
|
Component: General → Extension Compatibility
Comment 1•9 years ago
|
||
A cursory examination of the source code shows that this add-on is using nsIContentPolicy in the parent process (so it's going over the shim layer):
See https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Pitfalls_for_add-on_developers#With_the_shim_2
Assuming we don't have the WebExtension APIs available to do the blocking that this add-on is trying to do (since we could then theoretically port the Chrome version of this add-on to ease the maintenance burden on the author), the easiest solution would be for the add-on author to move the nsIContentPolicy implementation into a process script to run in the content process (the above link has documentation on process scripts).
Comment 2•9 years ago
|
||
Hey JorgeV, are we able to reach out to this add-on author to let them know about the performance problem here?
Flags: needinfo?(jorge)
Updated•9 years ago
|
Blocks: e10s-addons
Comment 4•9 years ago
|
||
Latest version 0.1.9 reviewed today should fixed those performance issues.
From the dev for this new version :
<< Regarding performance issue, I redesigned the blocking engine. It is now using the new "resource://gre/modules/WebRequest.jsm" instead of "nsIContentPolicy". By using WebRequest.jsm, the blocking core is now very similar to google chrome's version.
>>
| Reporter | ||
Comment 5•9 years ago
|
||
I tried out 0.1.9 and the page is still 0.5-1s slower to load with e10s
Updated•9 years ago
|
Flags: needinfo?(mconley)
| Reporter | ||
Comment 6•9 years ago
|
||
mconley and I had a look at this and the content process is doing sync messages to the chrome process in WebRequestContent. It looks like this is improved by bug 1163862.
| Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(mconley)
| Reporter | ||
Comment 7•9 years ago
|
||
This seems largely fixed now.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•