1250377 - create a ServoStyleSet for HTML documents in content docshells

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0be470ccd42

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Part 1: Use MOZ_STYLO environment variable to switch on Servo-backed style system.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Part 2: Stub out enough ServoStyleSet methods to be able to create one for a document.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Part 3: Create a ServoStyleSet for HTML documents in content docshells.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8722313 [details] [diff] [review]
Part 1: Use MOZ_STYLO environment variable to switch on Servo-backed style system.

Review of attachment 8722313 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that.

::: layout/base/nsPresContext.h
@@ +1071,5 @@
>  
> +  static bool StyloEnabled()
> +  {
> +    static bool enabled = PR_GetEnv("MOZ_STYLO");
> +    return enabled;

Please put this behind |#ifdef MOZ_STYLO|, and just return false otherwise.

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8722316 [details] [diff] [review]
Part 3: Create a ServoStyleSet for HTML documents in content docshells.

Review of attachment 8722316 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsDocumentViewer.cpp
@@ +2180,5 @@
> +  StyleSetHandle styleSet;
> +  if (backendType == StyleBackendType::Gecko) {
> +    styleSet = new nsStyleSet;
> +  } else {
> +    styleSet = new ServoStyleSet;

Can we keep the trailing (), here and above? I'd rather not change style conventions in this patch.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18a340cceaf3
https://hg.mozilla.org/integration/mozilla-inbound/rev/008aa54d8df6
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b9d0ccdf0dd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18a340cceaf3
https://hg.mozilla.org/mozilla-central/rev/008aa54d8df6
https://hg.mozilla.org/mozilla-central/rev/5b9d0ccdf0dd