No description provided.
std::max is only constexpr in c++14 and >, but we build as c++11 so initializing a constant with std::max ends up with a static constructor. Fortunately we have tl::Max around which forces evaluation of the math at compile time.
Attachment #8722492 - Flags: review?(rjesup)
It gets rid of a couple static constructors, and should make the build slightly faster since we compile less code.
Attachment #8722493 - Flags: review?(rjesup)
backlog: --- → webrtc/webaudio+
Priority: -- → P3
Attachment #8722492 - Flags: review?(rjesup) → review+
Attachment #8722493 - Flags: review?(rjesup) → review+
validation of removal of constructors via perfherder: https://treeherder.mozilla.org/perf.html#/alerts?id=578
You need to log in before you can comment on or make changes to this bug.