get rid of some static constructors in webRTC code

RESOLVED FIXED in Firefox 48

Status

()

defect
P3
normal
Rank:
35
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tbsaunde, Unassigned)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments)

No description provided.
std::max is only constexpr in c++14 and >, but we build as c++11 so
initializing a constant with std::max ends up with a static constructor.
Fortunately we have tl::Max around which forces evaluation of the math at
compile time.
Attachment #8722492 - Flags: review?(rjesup)
It gets rid of a couple static constructors, and should make the build slightly
faster since we compile less code.
Attachment #8722493 - Flags: review?(rjesup)
backlog: --- → webrtc/webaudio+
Rank: 35
Priority: -- → P3
Attachment #8722492 - Flags: review?(rjesup) → review+
Attachment #8722493 - Flags: review?(rjesup) → review+
validation of removal of constructors via perfherder:
https://treeherder.mozilla.org/perf.html#/alerts?id=578
https://hg.mozilla.org/mozilla-central/rev/432cfb0bde31
https://hg.mozilla.org/mozilla-central/rev/9f87c2e8231e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.