Closed
Bug 1250492
Opened 8 years ago
Closed 8 years ago
get rid of some static constructors in webRTC code
Categories
(Core :: WebRTC, defect, P3)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
backlog | webrtc/webaudio+ |
People
(Reporter: tbsaunde, Unassigned)
Details
Attachments
(2 files)
2.07 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
846 bytes,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•8 years ago
|
||
std::max is only constexpr in c++14 and >, but we build as c++11 so initializing a constant with std::max ends up with a static constructor. Fortunately we have tl::Max around which forces evaluation of the math at compile time.
Attachment #8722492 -
Flags: review?(rjesup)
Reporter | ||
Comment 2•8 years ago
|
||
It gets rid of a couple static constructors, and should make the build slightly faster since we compile less code.
Attachment #8722493 -
Flags: review?(rjesup)
Updated•8 years ago
|
backlog: --- → webrtc/webaudio+
Rank: 35
Priority: -- → P3
Updated•8 years ago
|
Attachment #8722492 -
Flags: review?(rjesup) → review+
Updated•8 years ago
|
Attachment #8722493 -
Flags: review?(rjesup) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/432cfb0bde31 https://hg.mozilla.org/integration/mozilla-inbound/rev/9f87c2e8231e
Comment 4•8 years ago
|
||
validation of removal of constructors via perfherder: https://treeherder.mozilla.org/perf.html#/alerts?id=578
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/432cfb0bde31 https://hg.mozilla.org/mozilla-central/rev/9f87c2e8231e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•