1250492 - get rid of some static constructors in webRTC code

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: use tl::Max instead of std::max to get rid of a static constructor

std::max is only constexpr in c++14 and >, but we build as c++11 so
initializing a constant with std::max ends up with a static constructor.
Fortunately we have tl::Max around which forces evaluation of the math at
compile time.

Comment 2

[Trevor Saunders (:tbsaunde)]

Attachment: include sstream in SdpMediaSection.h instead of iostream

It gets rid of a couple static constructors, and should make the build slightly
faster since we compile less code.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/432cfb0bde31
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f87c2e8231e

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

validation of removal of constructors via perfherder:
https://treeherder.mozilla.org/perf.html#/alerts?id=578

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/432cfb0bde31
https://hg.mozilla.org/mozilla-central/rev/9f87c2e8231e