1250499 - [Static Analysis][Resource Leak] In function mount_operation_ask_password

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[radu stoica]

The Static Analysis tool Coverity added \
possible Resource leak (RESOURCE_LEAK)

Comment 1

[radu stoica]

Attachment: bug_1250499.diff

Comment 2

[(no longer active)]

Comment on attachment 8722507 [details] [diff] [review]
bug_1250499.diff

Review of attachment 8722507 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/gio/nsGIOProtocolHandler.cpp
@@ +867,5 @@
>                                  &pass, &retval);
>    }
>    if (NS_FAILED(rv) || !retval) {  //  was || user == '\0' || pass == '\0'
>      g_mount_operation_reply(mount_op, G_MOUNT_OPERATION_ABORTED);
> +    free(user);

You're still leaking pass with this patch.  You need to free them both here.

Comment 3

[radu stoica]

Attachment: bug_1250499.diff

Comment 4

[(no longer active)]

Comment on attachment 8722955 [details] [diff] [review]
bug_1250499.diff

Review of attachment 8722955 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/gio/nsGIOProtocolHandler.cpp
@@ +874,5 @@
> +    }
> +    if (pass) {
> +      free(pass);
> +      pass = nullptr;
> +    }

free() can deal with a nullptr being passed to it, also since you're returning there is no point in resetting these variables to nullptr since they're on the stack.

I think it's enough to just free them both.

Comment 5

[radu stoica]

Attachment: bug_1250499.diff

ok, i've modified it

Comment 6

[(no longer active)]

Comment on attachment 8723523 [details] [diff] [review]
bug_1250499.diff

Review of attachment 8723523 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!  r=me

Comment 7

[radu stoica]

Attachment: bug_1250499.diff

Comment 8

[(no longer active)]

Dear sheriffs: this can be landed without a try run.  Thanks!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe8939c91205

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fe8939c91205