Closed Bug 1250523 Opened 9 years ago Closed 1 year ago

Intermittent browser_markup_load_01.js | The markup view is rendering - Got 0, expected 1

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox47 fixed)

Status:
RESOLVED INCOMPLETE
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: cbook, Unassigned)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

MozReview Request: Bug 1250523 - Wait for the markup-view to be loaded in browser_markup_load_01.js; r=gl
58 bytes, text/x-review-board-request
gl
: review+
Details
debugging-log.txt
19.22 KB, text/plain
Details 
https://treeherder.mozilla.org/logviewer.html#?job_id=7474990&repo=fx-team

 14:40:23 INFO - 5929 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_load_01.js | The markup view is rendering - Got 0, expected 1
This started failing when I landed bug 1244120 I think.
I'll take a look at this one.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: -- → P2
Just making the test more safe by waiting for the markup-view to be loaded fully fixes it.
I have re-triggered many many of the corresponding dt jobs on this try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c27ca9cf87da&group_state=expanded
Comment on attachment 8724750 [details]
MozReview Request: Bug 1250523 - Wait for the markup-view to be loaded in browser_markup_load_01.js; r=gl

https://reviewboard.mozilla.org/r/37143/#review33687
Attachment #8724750 - Flags: review?(gl) → review+
https://hg.mozilla.org/mozilla-central/rev/5496f32b7b5a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
This is still happening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Inspector bugs triage. Filter on CLIMBING SHOES.

Very frequent failures last week -> P1
Taking this one as Pbro will be on PTO next week.
Assignee: pbrosset → jdescottes
Status: REOPENED → ASSIGNED
Priority: P2 → P1
Attached file debugging-log.txt — 
If anyone happens to care, here are some pointers on where to look at.

tl;dr: After reload, the new root node does not have a BODY element as a descendant. HTML node is selected but it's parent node is different from the root node.

In the case when this test fails, the following sequence of events occurs after reload in the test:
1) A newRoot mutation gives inspector a new, previously unseen #document node with ID server1.conn44.domnode81 as the root node.
2) The new root handler goes on calling getDefaultNodeForSelection which tries to look for the IMG and BODY nodes as a descendant of the new root node but does not find either
3) It falls back to asking for the document element and receives HTML element that has a parent of server1.conn44.domnode86 which is different from the received new root node.

Eventually importNode is called for the HTML element and its parent but since the parent node of the HTML node was server1.conn44.domnode86 and the root node is server1.conn44.domnode81, [1] never passes and the markupview stays empty forever.

I've attached the relevant parts from a log extra with debugging information. The full log can be found from [2] (dunno how long it stays around)

[1] https://dxr.mozilla.org/mozilla-central/source/devtools/client/inspector/markup/markup.js#851
[2] http://archive.mozilla.org/pub/firefox/try-builds/sjakthol@outlook.com-1dc12cd2f9f37341fbfc079c0c65efcffd4d2a8a/try-linux64-debug/try_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm53-tests1-linux64-build1483.txt.gz
Component: Developer Tools → Developer Tools: Inspector
Adjusting the priority down since this doesn't fail as often as it used to now.
Priority: P1 → P3
Assignee: jdescottes → nobody
Status: ASSIGNED → NEW
Product: Firefox → DevTools
Severity: normal → S3

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.

Status: NEW → RESOLVED
Closed: 8 years ago → 1 year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: