Closed Bug 1250540 Opened 4 years ago Closed 4 years ago

Screen share stops working in Firefox Nightly

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed
Blocking Flags:

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(3 files)

As reported in dev.media today. The breakage was from this landing:

http://hg.mozilla.org/mozilla-central/diff/e22b3043887e/dom/media/MediaManager.cpp#l1.33

The third argument to Substring() is length.
backlog: --- → webrtc/webaudio+
Rank: 5
Priority: -- → P1
Comment on attachment 8722536 [details]
MozReview Request: Bug 1250540 - fix string-parsing regression that made screen share whitelisting stop working.

https://reviewboard.mozilla.org/r/36085/#review32693

doh!
Attachment #8722536 - Flags: review?(rjesup) → review+
Uh, that must have been a botched merge or something, because there's no reason I should have changed that code ...  sorry about that.
Comment on attachment 8722646 [details]
MozReview Request: Bug 1250540 - test media.getusermedia.screensharing.allowed_domains

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36159/diff/1-2/
Comment on attachment 8722645 [details]
MozReview Request: Bug 1250540 - have media.navigator.permission.disabled no longer bypass media.getusermedia.screensharing.allowed_domains.

https://reviewboard.mozilla.org/r/36157/#review32865
Attachment #8722645 - Flags: review?(rjesup) → review+
Comment on attachment 8722646 [details]
MozReview Request: Bug 1250540 - test media.getusermedia.screensharing.allowed_domains

https://reviewboard.mozilla.org/r/36159/#review32867
Attachment #8722646 - Flags: review?(rjesup) → review+
Since dom/animation/test/chrome/test_restyles.html (the intermittent crasher in https://treeherder.mozilla.org/#/jobs?repo=try&revision=a82b3bc128ae&selectedJob=17124602 ) doesn't use screensharing, I think we're good here. Landing.
You need to log in before you can comment on or make changes to this bug.