1250540 - Screen share stops working in Firefox Nightly

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

As reported in dev.media today. The breakage was from this landing:

http://hg.mozilla.org/mozilla-central/diff/e22b3043887e/dom/media/MediaManager.cpp#l1.33

The third argument to Substring() is length.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1250540 - fix string-parsing regression that made screen share whitelisting stop working.

Review commit: https://reviewboard.mozilla.org/r/36085/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36085/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8722536 [details]
MozReview Request: Bug 1250540 - fix string-parsing regression that made screen share whitelisting stop working.

https://reviewboard.mozilla.org/r/36085/#review32693

doh!

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Uh, that must have been a botched merge or something, because there's no reason I should have changed that code ...  sorry about that.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1250540 - have media.navigator.permission.disabled no longer bypass media.getusermedia.screensharing.allowed_domains.

Review commit: https://reviewboard.mozilla.org/r/36157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36157/

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1250540 - test media.getusermedia.screensharing.allowed_domains

Review commit: https://reviewboard.mozilla.org/r/36159/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36159/

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8722646 [details]
MozReview Request: Bug 1250540 - test media.getusermedia.screensharing.allowed_domains

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36159/diff/1-2/

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8722645 [details]
MozReview Request: Bug 1250540 - have media.navigator.permission.disabled no longer bypass media.getusermedia.screensharing.allowed_domains.

https://reviewboard.mozilla.org/r/36157/#review32865

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8722646 [details]
MozReview Request: Bug 1250540 - test media.getusermedia.screensharing.allowed_domains

https://reviewboard.mozilla.org/r/36159/#review32867

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Since dom/animation/test/chrome/test_restyles.html (the intermittent crasher in https://treeherder.mozilla.org/#/jobs?repo=try&revision=a82b3bc128ae&selectedJob=17124602 ) doesn't use screensharing, I think we're good here. Landing.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b1a92589f26
https://hg.mozilla.org/integration/mozilla-inbound/rev/637b9871727b
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a0d8138b277

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8b1a92589f26
https://hg.mozilla.org/mozilla-central/rev/637b9871727b
https://hg.mozilla.org/mozilla-central/rev/3a0d8138b277