Closed Bug 1250585 Opened 4 years ago Closed 4 years ago

beetmover - add push to mirrors

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
Tracking Status
firefox47 --- fixed

People

(Reporter: jlund, Assigned: jlund)

References

Details

Attachments

(4 files, 2 obsolete files)

No description provided.
* this also fixes bug where we take build/0 from tc artifacts regardless if
  there was a retry

Review commit: https://reviewboard.mozilla.org/r/36149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36149/
Attachment #8722633 - Flags: review?(rail)
Comment on attachment 8722633 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

it works locally!

python scripts/release/push-candidate-to-releases.py --product firefox --version 47.0b1 --build-number 5 --bucket mozilla-releng-beet-mover-dev

https://console.aws.amazon.com/s3/home?region=us-east-1#&bucket=mozilla-releng-beet-mover-dev&prefix=pub/firefox/releases/47.0b1/
Comment on attachment 8722633 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

https://reviewboard.mozilla.org/r/36149/#review32749

::: testing/mozharness/mozharness/mozilla/aws.py:9
(Diff revision 1)
> +    aws_secret_key = os.environ.get("AWS_SECRET_ACCESS_KEY")

I'd use something like

   `aws_key_id = os.environ.pop("AWS_ACCESS_KEY_ID", None)`

In this case you don't need to `del` items nor check if they are set. The current code won't delete the keys if you have one of them unset.
Attachment #8722633 - Flags: review?(rail)
Comment on attachment 8722634 [details]
MozReview Request: readds accidental deletion of mozharness import ref, r?rail

https://reviewboard.mozilla.org/r/36151/#review32753
Attachment #8722634 - Flags: review?(rail) → review+
Assignee: nobody → jlund
Attachment #8722773 - Flags: review?(rail)
Attachment #8722774 - Flags: review?(rail)
Comment on attachment 8722774 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

https://reviewboard.mozilla.org/r/36227/#review32801

::: buildfarm/release/release-runner.py:158
(Diff revision 1)
> +    return branch in ('mozilla-beta', 'date')

Can you move this to project_branches (branchConfig)? We don't automatically push mozilla-release, for example.
Attachment #8722773 - Flags: review?(rail) → review+
https://hg.mozilla.org/mozilla-central/rev/950003efdb8d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8722633 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

this landed with review comments addressed
Attachment #8722633 - Attachment is obsolete: true
Comment on attachment 8723088 [details]
MozReview Request: Bug 1250585 - uses branchConfig for push to releases is automatic, tools repo, r?rail

https://reviewboard.mozilla.org/r/36343/#review32919
Attachment #8723088 - Flags: review?(rail) → review+
Attachment #8723090 - Flags: review?(rail) → review+
Comment on attachment 8723090 [details]
MozReview Request: Bug 1250585 - adds push to mirrors automatic date, buildbot-configs, r?rail

https://reviewboard.mozilla.org/r/36347/#review32921
Attachment #8722774 - Attachment is obsolete: true
Attachment #8723088 - Flags: checked-in+
Attachment #8723090 - Flags: checked-in+
Attachment #8722773 - Flags: checked-in+
Attachment #8722634 - Flags: checked-in+
Depends on: 1254395
You need to log in before you can comment on or make changes to this bug.