Closed
Bug 1250585
Opened 5 years ago
Closed 5 years ago
beetmover - add push to mirrors
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jlund, Assigned: jlund)
References
Details
Attachments
(4 files, 2 obsolete files)
58 bytes,
text/x-review-board-request
|
rail
:
review+
jlund
:
checked-in+
|
Details |
48 bytes,
text/x-github-pull-request
|
rail
:
review+
jlund
:
checked-in+
|
Details | Review |
58 bytes,
text/x-review-board-request
|
rail
:
review+
jlund
:
checked-in+
|
Details |
58 bytes,
text/x-review-board-request
|
rail
:
review+
jlund
:
checked-in+
|
Details |
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
* this also fixes bug where we take build/0 from tc artifacts regardless if there was a retry Review commit: https://reviewboard.mozilla.org/r/36149/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36149/
Attachment #8722633 -
Flags: review?(rail)
Assignee | ||
Comment 2•5 years ago
|
||
Comment on attachment 8722633 [details] MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail it works locally! python scripts/release/push-candidate-to-releases.py --product firefox --version 47.0b1 --build-number 5 --bucket mozilla-releng-beet-mover-dev https://console.aws.amazon.com/s3/home?region=us-east-1#&bucket=mozilla-releng-beet-mover-dev&prefix=pub/firefox/releases/47.0b1/
Assignee | ||
Comment 3•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36151/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36151/
Attachment #8722634 -
Flags: review?(rail)
Comment 4•5 years ago
|
||
Comment on attachment 8722633 [details] MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail https://reviewboard.mozilla.org/r/36149/#review32749 ::: testing/mozharness/mozharness/mozilla/aws.py:9 (Diff revision 1) > + aws_secret_key = os.environ.get("AWS_SECRET_ACCESS_KEY") I'd use something like `aws_key_id = os.environ.pop("AWS_ACCESS_KEY_ID", None)` In this case you don't need to `del` items nor check if they are set. The current code won't delete the keys if you have one of them unset.
Attachment #8722633 -
Flags: review?(rail)
Comment 5•5 years ago
|
||
Comment on attachment 8722634 [details] MozReview Request: readds accidental deletion of mozharness import ref, r?rail https://reviewboard.mozilla.org/r/36151/#review32753
Attachment #8722634 -
Flags: review?(rail) → review+
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jlund
Assignee | ||
Comment 7•5 years ago
|
||
Attachment #8722773 -
Flags: review?(rail)
Assignee | ||
Comment 8•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36227/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36227/
Attachment #8722774 -
Flags: review?(rail)
Updated•5 years ago
|
Attachment #8722774 -
Flags: review?(rail)
Comment 9•5 years ago
|
||
Comment on attachment 8722774 [details] MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail https://reviewboard.mozilla.org/r/36227/#review32801 ::: buildfarm/release/release-runner.py:158 (Diff revision 1) > + return branch in ('mozilla-beta', 'date') Can you move this to project_branches (branchConfig)? We don't automatically push mozilla-release, for example.
Updated•5 years ago
|
Attachment #8722773 -
Flags: review?(rail) → review+
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/950003efdb8d
Assignee | ||
Comment 11•5 years ago
|
||
Comment on attachment 8722633 [details] MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail this landed with review comments addressed
Attachment #8722633 -
Attachment is obsolete: true
Assignee | ||
Comment 12•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36343/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36343/
Attachment #8723088 -
Flags: review?(rail)
Assignee | ||
Comment 13•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36347/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36347/
Attachment #8723090 -
Flags: review?(rail)
Comment 14•5 years ago
|
||
Comment on attachment 8723088 [details] MozReview Request: Bug 1250585 - uses branchConfig for push to releases is automatic, tools repo, r?rail https://reviewboard.mozilla.org/r/36343/#review32919
Attachment #8723088 -
Flags: review?(rail) → review+
Updated•5 years ago
|
Attachment #8723090 -
Flags: review?(rail) → review+
Comment 15•5 years ago
|
||
Comment on attachment 8723090 [details] MozReview Request: Bug 1250585 - adds push to mirrors automatic date, buildbot-configs, r?rail https://reviewboard.mozilla.org/r/36347/#review32921
Assignee | ||
Updated•5 years ago
|
Attachment #8722774 -
Attachment is obsolete: true
Assignee | ||
Updated•5 years ago
|
Attachment #8723088 -
Flags: checked-in+
Assignee | ||
Updated•5 years ago
|
Attachment #8723090 -
Flags: checked-in+
Assignee | ||
Updated•5 years ago
|
Attachment #8722773 -
Flags: checked-in+
Assignee | ||
Updated•5 years ago
|
Attachment #8722634 -
Flags: checked-in+
You need to log in
before you can comment on or make changes to this bug.
Description
•