1250585 - beetmover - add push to mirrors

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Comment 1

[Jordan Lund (:jlund)]

Attachment: MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

* this also fixes bug where we take build/0 from tc artifacts regardless if
  there was a retry

Review commit: https://reviewboard.mozilla.org/r/36149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36149/

Comment 2

[Jordan Lund (:jlund)]

Comment on attachment 8722633 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

it works locally!

python scripts/release/push-candidate-to-releases.py --product firefox --version 47.0b1 --build-number 5 --bucket mozilla-releng-beet-mover-dev

https://console.aws.amazon.com/s3/home?region=us-east-1#&bucket=mozilla-releng-beet-mover-dev&prefix=pub/firefox/releases/47.0b1/

Comment 3

[Jordan Lund (:jlund)]

Attachment: MozReview Request: readds accidental deletion of mozharness import ref, r?rail

Review commit: https://reviewboard.mozilla.org/r/36151/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36151/

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8722633 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

https://reviewboard.mozilla.org/r/36149/#review32749

::: testing/mozharness/mozharness/mozilla/aws.py:9
(Diff revision 1)
> +    aws_secret_key = os.environ.get("AWS_SECRET_ACCESS_KEY")

I'd use something like

   `aws_key_id = os.environ.pop("AWS_ACCESS_KEY_ID", None)`

In this case you don't need to `del` items nor check if they are set. The current code won't delete the keys if you have one of them unset.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8722634 [details]
MozReview Request: readds accidental deletion of mozharness import ref, r?rail

https://reviewboard.mozilla.org/r/36151/#review32753

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/950003efdb8d

Comment 7

[Jordan Lund (:jlund)]

Attachment: releasetasks scheduling

Comment 8

[Jordan Lund (:jlund)]

Attachment: MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

Review commit: https://reviewboard.mozilla.org/r/36227/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36227/

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8722774 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

https://reviewboard.mozilla.org/r/36227/#review32801

::: buildfarm/release/release-runner.py:158
(Diff revision 1)
> +    return branch in ('mozilla-beta', 'date')

Can you move this to project_branches (branchConfig)? We don't automatically push mozilla-release, for example.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/950003efdb8d

Comment 11

[Jordan Lund (:jlund)]

Comment on attachment 8722633 [details]
MozReview Request: Bug 1250585 - beetmover - add push to mirrors, r?rail

this landed with review comments addressed

Comment 12

[Jordan Lund (:jlund)]

Attachment: MozReview Request: Bug 1250585 - uses branchConfig for push to releases is automatic, tools repo, r?rail

Review commit: https://reviewboard.mozilla.org/r/36343/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36343/

Comment 13

[Jordan Lund (:jlund)]

Attachment: MozReview Request: Bug 1250585 - adds push to mirrors automatic date, buildbot-configs, r?rail

Review commit: https://reviewboard.mozilla.org/r/36347/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36347/

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 8723088 [details]
MozReview Request: Bug 1250585 - uses branchConfig for push to releases is automatic, tools repo, r?rail

https://reviewboard.mozilla.org/r/36343/#review32919

Comment 15

[Rail Aliiev [:rail]]

Comment on attachment 8723090 [details]
MozReview Request: Bug 1250585 - adds push to mirrors automatic date, buildbot-configs, r?rail

https://reviewboard.mozilla.org/r/36347/#review32921