125093 - move static nsStr routines into a private class

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Alec Flett]

so right now, the nsStr class is defined with NS_COM which means every method in
the class is being exported from xpcom.dll, which is especially annoying because
I have a feeling that not all of them are even used anymore.

This is something we've needed to do for some time, but basically I have moved
all the static member functions of nsStr into a private class, nsStrPrivate, and
updated all the string code as such. This class is NOT exported, which means the
linker will cull out the unused functions, thus reducing code bloat, etc etc.

This only affects the string library itself, but not any of the consumers

Another nice thing with this is that we can continue to hack away at
nsStrPrivate, removing/tweaking/etc, but we won't have to rebuild the tree every
time we change something.

Comment 1

[Alec Flett]

Attachment: move static functions into nsStrPrivate

I left the actual implementations in nsStr.cpp, just added a private header
file that's included by nsStr.cpp, nsString.cpp, and nsString2.cpp

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 69100 [details] [diff] [review]
move static functions into nsStrPrivate

r=dbaron

Comment 3

[Blake Ross]

Comment on attachment 69100 [details] [diff] [review]
move static functions into nsStrPrivate

sr=blake

Comment 4

[jag (Peter Annema)]

Comment on attachment 69100 [details] [diff] [review]
move static functions into nsStrPrivate

sr=jag fwiw

Comment 5

[Alec Flett]

landed