move static nsStr routines into a private class

RESOLVED FIXED in mozilla0.9.9

Status

()

Core
String
P2
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Alec Flett, Assigned: Alec Flett)

Tracking

Trunk
mozilla0.9.9
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fix in hand)

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
so right now, the nsStr class is defined with NS_COM which means every method in
the class is being exported from xpcom.dll, which is especially annoying because
I have a feeling that not all of them are even used anymore.

This is something we've needed to do for some time, but basically I have moved
all the static member functions of nsStr into a private class, nsStrPrivate, and
updated all the string code as such. This class is NOT exported, which means the
linker will cull out the unused functions, thus reducing code bloat, etc etc.

This only affects the string library itself, but not any of the consumers

Another nice thing with this is that we can continue to hack away at
nsStrPrivate, removing/tweaking/etc, but we won't have to rebuild the tree every
time we change something.
(Assignee)

Comment 1

16 years ago
Created attachment 69100 [details] [diff] [review]
move static functions into nsStrPrivate

I left the actual implementations in nsStr.cpp, just added a private header
file that's included by nsStr.cpp, nsString.cpp, and nsString2.cpp
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: fix in hand
Target Milestone: --- → mozilla0.9.9
Comment on attachment 69100 [details] [diff] [review]
move static functions into nsStrPrivate

r=dbaron
Attachment #69100 - Flags: review+

Comment 3

16 years ago
Comment on attachment 69100 [details] [diff] [review]
move static functions into nsStrPrivate

sr=blake
Attachment #69100 - Flags: superreview+

Comment 4

16 years ago
Comment on attachment 69100 [details] [diff] [review]
move static functions into nsStrPrivate

sr=jag fwiw
(Assignee)

Comment 5

16 years ago
landed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.