1250997 - Many favicons are not being loaded in home panels

Status: RESOLVED DUPLICATE of bug 1254465

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Chenxia Liu [:liuche]]

support.mozilla.org doesn't ever load and subsequently never gets saved to the cache to be displayed in home panels. I've had some problems with favicons on the home panels for Wikipedia subpages as well as for google: visiting the root domain of some sites will work, but fails to load favicons in History otherwise. (These favicons load fine in Chrome.)

A lot more of the favicons in home panels are the default icon, it seems.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

I assume that's because of bug 765064.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> I assume that's because of bug 765064.

Let's do a little digging to confirm SNI is the cause. If so, I think it's time to deal with SNI.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

That's what I get when opening SUMO:

> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: javax.net.ssl.SSLHandshakeException: Handshake failed
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:396)
> [..]
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: 	at org.mozilla.gecko.favicons.LoadFaviconTask.downloadFavicon(LoadFaviconTask.java:226)
> [..]
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: Caused by: javax.net.ssl.SSLProtocolException: SSL handshake terminated: ssl=0xd1ae3780: Failure in SSL library, usually a protocol error
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: error:100c5410:SSL routines:ssl3_read_bytes:SSLV3_ALERT_HANDSHAKE_FAILURE (external/boringssl/src/ssl/s3_pkt.c:972 0xeef5fcc0:0x00000001)
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: error:100c009f:SSL routines:ssl3_get_server_hello:HANDSHAKE_FAILURE_ON_CLIENT_HELLO (external/boringssl/src/ssl/s3_clnt.c:750 0xeb3704f7:0x00000000)
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: 	at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:324)
> 02-24 13:56:29.277 31223 31930 E LoadFaviconTask: 	... 18 more

This looks a lot like the stacktrace I got when we switched the CDN for DLC (caused by SNI).

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

This are two separate issues: I addressed loading of favicons from hosts using SNI in bug 1254089. This fixes SUMO and other pages. For subpages not loading a favicon I filed a new bug: Bug 1254465.