Closed
Bug 1251044
Opened 9 years ago
Closed 9 years ago
content length should use the content-range values if available
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(2 files)
Follow up on bug 1249904.
In bug 1249904, changes were made to use the content-range values should the content length not be available. The changes were made to limit the change to existing behaviour (and make that patch safe to uplift)
As per roc's comment:
"we should use the max of contentLength and rangeTotal. I know of no reason to ignore rangeTotal just because we have contentLength. We know contentLength can be incorrect."
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36565/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36565/
Attachment #8723449 -
Flags: review?(roc)
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36567/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36567/
Attachment #8723450 -
Flags: review?(roc)
Attachment #8723449 -
Flags: review?(roc) → review+
Comment on attachment 8723449 [details]
MozReview Request: Bug 1251044: P1. Use content-range values to determine content's length. r?roc
https://reviewboard.mozilla.org/r/36565/#review33541
Attachment #8723450 -
Flags: review?(roc)
Comment on attachment 8723450 [details]
MozReview Request: Bug 1251044: P2. Remove dead code and generalise the use of content-range header. r?roc
https://reviewboard.mozilla.org/r/36567/#review33543
great, thanks
Comment on attachment 8723450 [details]
MozReview Request: Bug 1251044: P2. Remove dead code and generalise the use of content-range header. r?roc
https://reviewboard.mozilla.org/r/36567/#review33581
Attachment #8723450 -
Flags: review+
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fb4a661e0378
https://hg.mozilla.org/mozilla-central/rev/1b82b05fc937
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•