Closed Bug 1251044 Opened 4 years ago Closed 4 years ago

content length should use the content-range values if available

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(2 files)

Follow up on bug 1249904.

In bug 1249904, changes were made to use the content-range values should the content length not be available. The changes were made to limit the change to existing behaviour (and make that patch safe to uplift)

As per roc's comment:
"we should use the max of contentLength and rangeTotal. I know of no reason to ignore rangeTotal just because we have contentLength. We know contentLength can be incorrect."
Assignee: nobody → jyavenard
Comment on attachment 8723449 [details]
MozReview Request: Bug 1251044: P1. Use content-range values to determine content's length. r?roc

https://reviewboard.mozilla.org/r/36565/#review33541
Comment on attachment 8723450 [details]
MozReview Request: Bug 1251044: P2. Remove dead code and generalise the use of content-range header. r?roc

https://reviewboard.mozilla.org/r/36567/#review33543

great, thanks
Comment on attachment 8723450 [details]
MozReview Request: Bug 1251044: P2. Remove dead code and generalise the use of content-range header. r?roc

https://reviewboard.mozilla.org/r/36567/#review33581
Attachment #8723450 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/fb4a661e0378
https://hg.mozilla.org/mozilla-central/rev/1b82b05fc937
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.