1251044 - content length should use the content-range values if available

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

Follow up on bug 1249904.

In bug 1249904, changes were made to use the content-range values should the content length not be available. The changes were made to limit the change to existing behaviour (and make that patch safe to uplift)

As per roc's comment:
"we should use the max of contentLength and rangeTotal. I know of no reason to ignore rangeTotal just because we have contentLength. We know contentLength can be incorrect."

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1251044: P1. Use content-range values to determine content's length. r?roc

Review commit: https://reviewboard.mozilla.org/r/36565/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36565/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1251044: P2. Remove dead code and generalise the use of content-range header. r?roc

Review commit: https://reviewboard.mozilla.org/r/36567/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36567/

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8723449 [details]
MozReview Request: Bug 1251044: P1. Use content-range values to determine content's length. r?roc

https://reviewboard.mozilla.org/r/36565/#review33541

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8723450 [details]
MozReview Request: Bug 1251044: P2. Remove dead code and generalise the use of content-range header. r?roc

https://reviewboard.mozilla.org/r/36567/#review33543

great, thanks

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8723450 [details]
MozReview Request: Bug 1251044: P2. Remove dead code and generalise the use of content-range header. r?roc

https://reviewboard.mozilla.org/r/36567/#review33581

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb4a661e0378
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b82b05fc937

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb4a661e0378
https://hg.mozilla.org/mozilla-central/rev/1b82b05fc937