Intermittent browser_bookmark_popup.js | Check that panel state is 'open' - Got closed, expected open

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: jaws)

Tracking

({intermittent-failure})

unspecified
Firefox 47
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Comment 1

3 years ago
Seen on Windows and Linux so far.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Created attachment 8723398 [details]
MozReview Request: Bug 1251107 - Move the mouseout code to popupHideFn(). r?gijs

The mouseout code triggers the hiding of the popup, but it was previously in the popupEditFn meaning that it ran before we expected the popup to close, which caused this race condition. I also had to tweak the contextmenu test because it was depending on a mousedown/click which we are no longer listening for (we replaced that with mouseover/mouseout).

Review commit: https://reviewboard.mozilla.org/r/36521/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36521/
Attachment #8723398 - Flags: review?(gijskruitbosch+bugs)

Comment 3

3 years ago
Comment on attachment 8723398 [details]
MozReview Request: Bug 1251107 - Move the mouseout code to popupHideFn(). r?gijs

https://reviewboard.mozilla.org/r/36521/#review33117

I have to admit that I don't understand the context menu change. Why isn't that test perma-failing right now, if the listeners in the code it's testing have already been changed? r=me, I guess, but an explanation would still be nice...
Attachment #8723398 - Flags: review?(gijskruitbosch+bugs) → review+
Because we didn't have a test condition inside `if (!shouldAutoClose)` that looked to see if the panel was still open. I added it in this patch.
Keywords: checkin-needed
7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 4
* try: 2
* mozilla-inbound: 1

Platform breakdown:
* osx-10-6: 2
* linux64: 2
* windows7-32: 1
* osx-10-10: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1251107&startday=2016-02-22&endday=2016-02-28&tree=all

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/48d839aa329b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.