Closed Bug 1251107 Opened 4 years ago Closed 4 years ago

Intermittent browser_bookmark_popup.js | Check that panel state is 'open' - Got closed, expected open

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: RyanVM, Assigned: jaws)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Seen on Windows and Linux so far.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
The mouseout code triggers the hiding of the popup, but it was previously in the popupEditFn meaning that it ran before we expected the popup to close, which caused this race condition. I also had to tweak the contextmenu test because it was depending on a mousedown/click which we are no longer listening for (we replaced that with mouseover/mouseout).

Review commit: https://reviewboard.mozilla.org/r/36521/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36521/
Attachment #8723398 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8723398 [details]
MozReview Request: Bug 1251107 - Move the mouseout code to popupHideFn(). r?gijs

https://reviewboard.mozilla.org/r/36521/#review33117

I have to admit that I don't understand the context menu change. Why isn't that test perma-failing right now, if the listeners in the code it's testing have already been changed? r=me, I guess, but an explanation would still be nice...
Attachment #8723398 - Flags: review?(gijskruitbosch+bugs) → review+
Because we didn't have a test condition inside `if (!shouldAutoClose)` that looked to see if the panel was still open. I added it in this patch.
https://hg.mozilla.org/mozilla-central/rev/48d839aa329b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.