1251126 - Intermittent browser_bookmark_popup.js | application crashed [@ nsNavBookmarks::OnDeleteURI(nsIURI*, nsACString_internal const&, unsigned short)] after Assertion failure: history && ((bool)(__builtin_expect(!!(!NS_FAILED_impl(history->GetIdForPage(aURI, &

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=22283674&repo=mozilla-inbound

Comment 1

[Marco Bonardo [:mak]]

 MOZ_ASSERT(
  history && NS_SUCCEEDED(history->GetIdForPage(aURI, &placeId, placeGuid)) && !placeId,
  "OnDeleteURI was notified for a page that still exists?"
);

Now, supposed history is alive, something is notifying an onDeleteURI for a page that has not been deleted, that's not good.
I'll have to audit all onDeleteURI notifiers to ensure we are not doing stupidities.

Comment 2

[Marco Bonardo [:mak]]

there is another possibility, that after we remove a bookmark expiration runs, removes the page, but before we notify uri removal, another bookmark to the same uri is added back...

Comment 3

[Justin Dolske [:Dolske]]

If bug 1219794 caused this, how important is this to fix? 47 is close to shipping, is this something that could have end-user impact?

Comment 4

[Marco Bonardo [:mak]]

It's not critical to fix it, at a maximum some consumer may temporarily think a given uri has been removed (it may disappear from a view).
Unfortunately I was unable to reproduce this problem in my tries, and that makes it harder to fix.
Could be a race condition as I supposed in comment 2, that makes it even harder to figure, but at the same time it would make it a false positive. Indeed the removal notification would be correct and there would be an addition notification immediately after that.

Comment 5

[Marco Bonardo [:mak]]

(note, this is likely due to the fact currently we have 2 bookmarking APIs, one synchronous one asynchronous. We should really find the time to complete deprecation of the old one)

Comment 6

[Justin Dolske [:Dolske]]

Ok, removing from our QX tracking then.

Comment 7

[Marco Bonardo [:mak]]

needs better STR

Comment 8

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* mozilla-aurora: 1

Platform breakdown:
* linux32: 4
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1251126&startday=2016-05-30&endday=2016-06-05&tree=all

Comment 9

[Intermittent Failures Robot]

6 failures in 690 pushes (0.009 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 4
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 3
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1251126&startday=2017-01-16&endday=2017-01-22&tree=all

Comment 10

[Intermittent Failures Robot]

8 failures in 749 pushes (0.011 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 3
* autoland: 3
* mozilla-central: 2

Platform breakdown:
* linux64: 4
* linux32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1251126&startday=2017-01-23&endday=2017-01-29&tree=all

Comment 11

[Intermittent Failures Robot]

8 failures in 836 pushes (0.01 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* autoland: 6
* mozilla-central: 2

Platform breakdown:
* linux32: 4
* linux64: 3
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1251126&startday=2017-02-06&endday=2017-02-12&tree=all

Comment 12

[Intermittent Failures Robot]

6 failures in 833 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 1
* graphics: 1
* autoland: 1

Platform breakdown:
* linux32: 4
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1251126&startday=2017-02-13&endday=2017-02-19&tree=all

Comment 13

[Intermittent Failures Robot]

12 failures in 790 pushes (0.015 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 5
* autoland: 4
* try: 1
* mozilla-central: 1
* graphics: 1

Platform breakdown:
* linux64: 9
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1251126&startday=2017-03-06&endday=2017-03-12&tree=all

Comment 15

[Marco Bonardo [:mak]]

Fixed by bug 1344205.