Closed
Bug 1251134
Opened 7 years ago
Closed 7 years ago
Intermittent browser_bookmark_popup.js | Check that panel state is 'open' - Got closed, expected open
Categories
(Firefox :: Bookmarks & History, defect, P5)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 49
People
(Reporter: philor, Assigned: jaws)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Priority: -- → P5
Updated•7 years ago
|
Assignee: nobody → jaws
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•7 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/56968/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56968/
Attachment #8758842 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 8•7 years ago
|
||
This appears to be happening because of the yield three lines above. We already check the panel state after the popupShown promise has been resolved, so this is redundant and somewhat oddly placed. https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=28043777#L2424 shows the failure is happening after the popup has already been confirmed to be "open" and that the popup should autoclose. Nine lines later there is a check to see that the popup is still open if it should not have autoclosed, so all cases are already covered.
Comment 9•7 years ago
|
||
Comment on attachment 8758842 [details] MozReview Request: Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r?gijs https://reviewboard.mozilla.org/r/56968/#review53910
Attachment #8758842 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 10•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/28b383d15b1a Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r=gijs
Keywords: checkin-needed
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/28b383d15b1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•7 years ago
|
status-firefox48:
--- → affected
Whiteboard: [checkin-needed-beta]
Comment 12•7 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/5d16ea3dd89a
Whiteboard: [checkin-needed-beta]
You need to log in
before you can comment on or make changes to this bug.
Description
•