Closed Bug 1251134 Opened 4 years ago Closed 3 years ago

Intermittent browser_bookmark_popup.js | Check that panel state is 'open' - Got closed, expected open

Categories

(Firefox :: Bookmarks & History, defect, P5)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: philor, Assigned: jaws)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

MozReview Request: Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r?gijs
58 bytes, text/x-review-board-request
Gijs
: review+
Details
Blocks: 1219794
Assignee: nobody → jaws
Status: NEW → ASSIGNED
This appears to be happening because of the yield three lines above. We already check the panel state after the popupShown promise has been resolved, so this is redundant and somewhat oddly placed.

https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=28043777#L2424 shows the failure is happening after the popup has already been confirmed to be "open" and that the popup should autoclose.

Nine lines later there is a check to see that the popup is still open if it should not have autoclosed, so all cases are already covered.
Comment on attachment 8758842 [details]
MozReview Request: Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r?gijs

https://reviewboard.mozilla.org/r/56968/#review53910
Attachment #8758842 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/28b383d15b1a
Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r=gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/28b383d15b1a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
status-firefox48: --- → affected
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.