1251159 - [Sync Tabs Sidebar] search filter doesn't show the "clear filter" "X" button

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P2)

Description

[Mark Hammond [:markh] [:mhammond]]

When you enter a string in the filter box, the magnifying-glass icon should be removed and a new "x" icon shown that clears the filter.

I thought I fixed that in bug 1244481, but apparently not.

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1251159.patch

Got it!

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/95f6c8a20a2a

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95f6c8a20a2a

Comment 4

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: bug.png

I've tested on Mac OS X 10.9.5 using latest Nightly 48.0a1 (buildID: 20160410030224): when I enter a string in the filter box, a new "x" icon is displayed in the filter box, but the magnifying-glass icon is also kept filter box, is not removed; I have in the filter box both magnifying-glass icon and "x" icon. It is intended behaviour? Please see attached screenshot "bug.png".

Comment 5

[Edouard Oger [:eoger]]

This is intended, the bookmarks and history sidebars exhibit the same behavior.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Camelia, can you please verify the behaviour of the Synced Tabs sidebar is the same as the other sidebars in this regard?

Comment 7

[Camelia Badau [:cbadau], Desktop Test Engineering]

I've verified on latest Nightly 48.0a1 (buildID: 20160413030239) on Mac OS X 10.9.5 and Synced Tabs Sidebar has the same behaviour as the other sidebars (History, Bookmarks): in the filter box both icons are displayed (magnifying-glass icon and "x" icon).