1251181 - Build with unified sources disabled

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

I've found that our build is broken with unified builds disabled. Often headers are missing from source files that need them and there are some instances of source files using functions not declared in headers. This can lead to changes in one source file causing build errors in others.

Once we get the current situation fixed, we should get a builder going to make sure we don't get back into this situation.

Comment 1

[Phil Ringnalda (:philor)]

What has changed since a year ago when we turned off the periodic nonunified builds, expecting exactly that? I don't see a new dev.platform thread about deciding to reverse course.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Phil Ringnalda (:philor) from comment #1)
> What has changed since a year ago when we turned off the periodic nonunified
> builds, expecting exactly that? I don't see a new dev.platform thread about
> deciding to reverse course.

Can you point me to this discussion?

Comment 3

[Phil Ringnalda (:philor)]

Since https://groups.google.com/d/topic/mozilla.dev.platform/7-BpQKQ8pSo/discussion was the after-the-fact discussion, I'm guessing the before-the-fact one misspelled unified, or it was our other style of decision-making and there was only the after-the-fact one.

Comment 4

[Jean-Yves Avenard [:jya]]

Shouldn't we resume this discussion?

Comment 5

[(not currently active) Ted Mielczarek]

I don't see why. I think Ehsan summed up the state of things pretty well in his posts:
https://groups.google.com/d/msg/mozilla.dev.platform/7-BpQKQ8pSo/irh8ntgt7_8J
https://groups.google.com/d/msg/mozilla.dev.platform/7-BpQKQ8pSo/VDm1m4xLfm8J

We removed the configure option, so this is no longer a supported build configuration.