Closed Bug 1251181 Opened 4 years ago Closed 2 years ago

Build with unified sources disabled

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: blassey, Unassigned)

References

Details

I've found that our build is broken with unified builds disabled. Often headers are missing from source files that need them and there are some instances of source files using functions not declared in headers. This can lead to changes in one source file causing build errors in others.

Once we get the current situation fixed, we should get a builder going to make sure we don't get back into this situation.
What has changed since a year ago when we turned off the periodic nonunified builds, expecting exactly that? I don't see a new dev.platform thread about deciding to reverse course.
Blocks: 1121017
Component: Release Automation → General Automation
QA Contact: bhearsum → catlee
(In reply to Phil Ringnalda (:philor) from comment #1)
> What has changed since a year ago when we turned off the periodic nonunified
> builds, expecting exactly that? I don't see a new dev.platform thread about
> deciding to reverse course.

Can you point me to this discussion?
Flags: needinfo?(philringnalda)
Since https://groups.google.com/d/topic/mozilla.dev.platform/7-BpQKQ8pSo/discussion was the after-the-fact discussion, I'm guessing the before-the-fact one misspelled unified, or it was our other style of decision-making and there was only the after-the-fact one.
Flags: needinfo?(philringnalda)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Shouldn't we resume this discussion?
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Component: General Automation → Build Config
Product: Release Engineering → Core
QA Contact: catlee
I don't see why. I think Ehsan summed up the state of things pretty well in his posts:
https://groups.google.com/d/msg/mozilla.dev.platform/7-BpQKQ8pSo/irh8ntgt7_8J
https://groups.google.com/d/msg/mozilla.dev.platform/7-BpQKQ8pSo/VDm1m4xLfm8J

We removed the configure option, so this is no longer a supported build configuration.
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.