Closed Bug 1251226 Opened 7 years ago Closed 7 years ago

Avoid passing a std::wstring through the variadic method

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Avoid passing a std::wstring through the variadic method
1.14 KB, patch
bobowen
: review+
Details | Diff | Splinter Review 
clang-cl emits the following error:

 9:39.10 c:/Users/ehsan/moz/src/ipc/glue/GeckoChildProcessHost.cpp(1037,9) :  error(clang): cannot pass object of non-trivial type 'const std::wstring' (aka 'co
nst basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t> >') through variadic method; call will abort at runtime [-Wnon-pod-varargs]
 9:39.10         cmdLine.command_line_string());
 9:39.10         ^
 9:39.10 1 error generated.
Attachment #8723554 - Flags: review?(bobowen.code) → review+
https://hg.mozilla.org/mozilla-central/rev/4f9b57948d0a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.