Closed Bug 1251237 Opened 10 years ago Closed 10 years ago

[CID 1351138] Uninitialized pointer read

Categories

(NSS :: Libraries, defect)

defect
Not set
normal

Tracking

(firefox47 affected)

RESOLVED INVALID
Tracking Status
firefox47 --- affected

People

(Reporter: franziskus, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1351138)

This is a follow up to bug 1223749. We have to check if result and tmp are set in ecp_256_32.c:from_montgomery > mp_clear(&result); > mp_clear(&tmp); because > MP_CHECKOK(mp_init(&result)); > MP_CHECKOK(mp_init(&tmp)); might fail.
ok, mp_clear actually checks this there should be no problem. The bit coverity complains about is > if(mp == NULL) > return; > > if(DIGITS(mp) != NULL) { DIGITS(mp) accesses mp->dp, which is fine because mp != NULL here.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.