Closed Bug 1251256 Opened 9 years ago Closed 9 years ago

Clear icon in devtools is ambigous

Categories

(DevTools :: Framework, defect, P3)

Product:
DevTools
Component:
Framework
Type:
defect

Tracking

(firefox46 unaffected, firefox47+ verified, firefox48 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox46 --- unaffected
firefox47 + verified
firefox48 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

Details

(Whiteboard: [devtools-ux][btpp-backlog])

Attachments

(2 files, 3 obsolete files)

clear-final.svg
469 bytes, image/svg+xml
hholmes
: ui-review+
Details
Patch
1.44 KB, patch
bgrins
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
It means "This is prohibited" rather than "Clear this". A trash can would work better in my opinion.
Whiteboard: [devtools-ux]
Assignee: nobody → hholmes
Priority: -- → P3
Whiteboard: [devtools-ux] → [devtools-ux][btpp-backlog]
These are some SVGs I put up for testing (mainly because of pixel-snapping concerns).
Attachment #8733574 - Attachment description: clear-rounded-corners.svg → clear-rounded-corners.svg - coordinates not pixel snapped

    
    

    
  
attachment 8733574 [details] and attachment 8733580 [details] basically produce the same result. The resulting icon is not blurry, but the lateral lines are a bit thinner.

    
    

    
  

      
      
      
      

        Attached image
          
        no-bottom-round-corners.svg (obsolete)
        — 
      

    


  
See Also:  → 1220208

    
    

    
  

      
      
      
      

        Attached image
          
        clear-final.svg
        — 
      

    


  
I decided to go with this icon, for more consistency. The thin icon can be applied once all other icons will be changed to thinner icons.

        Attachment #8733574 -
        Attachment is obsolete: true

        Attachment #8733580 -
        Attachment is obsolete: true

        Attachment #8733609 -
        Attachment is obsolete: true

        Attachment #8734918 -
        Flags: ui-review?(hholmes)

        Attachment #8734918 -
        Flags: ui-review?(hholmes) → ui-review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  
Helen, Thanks for the review!
Assignee: hholmes → ntim.bugs
Status: NEW → ASSIGNED

        Attachment #8735433 -
        Flags: review?(bgrinstead)

    
    

    
  
[Tracking Requested - why for this release]: The clear icon was introduced in Firefox 47, and having 2 different clear icons across 2 subsequent releases feels confusing. Let's have 1 common icon across Firefox 47 and 48

          status-firefox46:
          --- → affected

          status-firefox47:
          --- → affected

          tracking-firefox46:
          --- → ?

    
    

    
  
Comment on attachment 8735433 [details] [diff] [review]
Patch

Review of attachment 8735433 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me

        Attachment #8735433 -
        Flags: review?(bgrinstead) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e5c8ba7cabaa
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox48:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

    
    

    
  
Comment on attachment 8735433 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: New clear icon introduced in 47
[User impact if declined]: Different icons across 2 different versions which might confuse users when they upgrade to 48
[Describe test coverage new/current, TreeHerder]: on Nightly
[Risks and why]: Low, image only change
[String/UUID change made/needed]: none

        Attachment #8735433 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8735433 [details] [diff] [review]
Patch

SVG change, the new icon is more appropriate and consistent, Aurora47+

        Attachment #8735433 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Successfully reproduce this bug on Nightly 47.0a1 (2016-02-25) (Build ID: 20160225030209) on Linux, 64 Bit.

This Bug is now verified as fixed on Latest Firefox Nightly (2016-04-14) ; (Build ID: 20160414030247)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0 and

Latest Firefox Developer Edition 47.0a2 (2016-04-14) ; (Build ID: 20160414004009)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
OS: Linux 3.19.0-58-generic x86-64
QA Whiteboard: [testday-20160415]

    
  
Status: RESOLVED → VERIFIED

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: