1251272 - ReportErrorRunnable::ReportError only pretends to be fallible

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It has some JSAPI that _is_ fallible, but is dead code.  And apart from that it only returns false if it fails to dispatch a runnable, but none of its consumers really seem to care about that.  One just checks the return value to report a JS exception.  The other returns the return value from WorkerRun, which is then propagated to PostRun, where it's used to report a JS exception.  But since we can't have an exception to start with...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the dead code in ReportErrorRunnable::ReportError that could fail, and make it infallible

Comment 2

[Boris Zbarsky [:bzbarsky]]

Oh, and we do still want to pass in a JSContext here, because we get the global from it and do stuff with that.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8723612 [details] [diff] [review]
Remove the dead code in ReportErrorRunnable::ReportError that could fail, and make it infallible

Review of attachment 8723612 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.cpp
@@ -960,5 @@
> -    JS::Rooted<JSString*> filename(aCx, JS_NewUCStringCopyN(aCx, aFilename.get(),
> -                                                            aFilename.Length()));
> -    if (!filename) {
> -      return false;
> -    }

Ouch.  Can't believe I left this here ...

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0685962294de

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0685962294de