Closed Bug 1251275 Opened 5 years ago Closed 5 years ago

Use AutoEntryScript for firing setTimeout/setInterval callbacks on workers

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Whiteboard: btpp-active)

Attachments

(2 files, 2 obsolete files)

Currently we manually report exceptions here.  We do have an AutoEntryScript set up already from Run (the caller of TimerRunnable::WorkerRun), but we really want a separate one for each timeout callback we run.  This also allows us to provide a better execution reason string.
Attached patch Diff -w for review convenience (obsolete) — Splinter Review
Attachment #8723616 - Attachment is obsolete: true
Attachment #8723616 - Flags: review?(khuey)
Attached patch Diff -wSplinter Review
Attachment #8723617 - Attachment is obsolete: true
Comment on attachment 8723702 [details] [diff] [review]
Patch, but with the obvious TakeOwnershipOfErrorReporting() we need

Review of attachment 8723702 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.cpp
@@ +5963,5 @@
> +      reason = "setInterval handler";
> +    } else {
> +      reason = "setTimeout handler";
> +    }
> +    { // scope for the AutoEntryScript, so it comes off the stack before we do

nit: \n between the two scopes
Attachment #8723702 - Flags: review?(khuey) → review+
> nit: \n between the two scopes

Done.
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/c10b6b14fce1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.