Make sure that debug builds use "default" update channel

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rail, Assigned: jlund)

Tracking

(Blocks: 1 bug)

unspecified

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

See bug 1242084 for the details.
(Assignee)

Comment 1

2 years ago
Created attachment 8723761 [details]
MozReview Request: Bug 1251288 - Make sure that debug builds use default update channel, r?rail

I tested this via running fx_desktop_build.py with and without this patch and
compared self.config:
```
./scripts/fx_desktop_build.py --cfg
configs/builds/releng_base_linux_64_builds.py --custom-build-variant-cfg debug
--branch date --build-pool production --developer-run --dump-config
```
diff -pU 10 logs/localconfig_without_patch.json logs/localconfig_with_patch.json

here is the diff of the above:
http://people.mozilla.org/~jlund/update-channel-self-config.diff

Review commit: https://reviewboard.mozilla.org/r/36713/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36713/
Attachment #8723761 - Flags: review?(rail)
Comment on attachment 8723761 [details]
MozReview Request: Bug 1251288 - Make sure that debug builds use default update channel, r?rail

https://reviewboard.mozilla.org/r/36713/#review33275
Attachment #8723761 - Flags: review?(rail) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → jlund
Ryan,

this patch explicitly set the update channel to "default" for mozilla-release and mozilla-beta mozharness based builds that are not supposed to be used in release promotion (non-opt builds, e.g. debug, haz, etc.). Any concerns if we land this change?
Flags: needinfo?(ryanvm)
SGTM. I'm going to have to figure out how to update the simulation patches to account for this change, but I'm sure we can figure it out.
Flags: needinfo?(ryanvm)
Comment on attachment 8723761 [details]
MozReview Request: Bug 1251288 - Make sure that debug builds use default update channel, r?rail

I pushed this to inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/fd9990a554a2
Attachment #8723761 - Flags: checked-in+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd9990a554a2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.