1251288 - Make sure that debug builds use "default" update channel

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

See bug 1242084 for the details.

Comment 1

[Jordan Lund (:jlund)]

Attachment: MozReview Request: Bug 1251288 - Make sure that debug builds use default update channel, r?rail

I tested this via running fx_desktop_build.py with and without this patch and
compared self.config:
```
./scripts/fx_desktop_build.py --cfg
configs/builds/releng_base_linux_64_builds.py --custom-build-variant-cfg debug
--branch date --build-pool production --developer-run --dump-config
```
diff -pU 10 logs/localconfig_without_patch.json logs/localconfig_with_patch.json

here is the diff of the above:
http://people.mozilla.org/~jlund/update-channel-self-config.diff

Review commit: https://reviewboard.mozilla.org/r/36713/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36713/

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8723761 [details]
MozReview Request: Bug 1251288 - Make sure that debug builds use default update channel, r?rail

https://reviewboard.mozilla.org/r/36713/#review33275

Comment 3

[Rail Aliiev [:rail]]

Ryan,

this patch explicitly set the update channel to "default" for mozilla-release and mozilla-beta mozharness based builds that are not supposed to be used in release promotion (non-opt builds, e.g. debug, haz, etc.). Any concerns if we land this change?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

SGTM. I'm going to have to figure out how to update the simulation patches to account for this change, but I'm sure we can figure it out.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8723761 [details]
MozReview Request: Bug 1251288 - Make sure that debug builds use default update channel, r?rail

I pushed this to inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/fd9990a554a2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fd9990a554a2