1251306 - Implement fallback read-only mode for never-synced state

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Richard Newman [:rnewman]]

This is like Bug 1201109, but on top of Bug 1201110.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

Check the last few commits -- this builds on top of #1551.

Commit messages are descriptive.

You can test this as follows:

* Clean install.
* Flip AppConstants.shouldMergeBookmarks to false.
* Sync with an account with bookmarks.
* You should see Desktop Bookmarks, be able to browse it, etc.
* You should not be able to delete desktop bookmarks.
* You should be able to delete local mobile bookmarks.
* You shouldn't be able to delete folders anywhere.
* None of your local changes will be uploaded to the server.

Comment 2

[Richard Newman [:rnewman]]

Note that there's an async-fetch TODO in there. Working on that now, but won't be done today. I might just not bother with that -- it's a can of worms.

Comment 3

[Richard Newman [:rnewman]]

Done, and I fixed a few other lurking bugs while I was there.

Comment 4

[Emily Toop (:fluffyemily)]

Comment on attachment 8724293 [details] [review]
Pull req.

This still doesn't work for me (see attachments for logs). I tried in these 4 circumstances and got the same behaviour:

On fresh install: shouldMergeBookmarks=false
On fresh install: shouldMergeBookmarks=true
On Upgrade: shouldMergeBookmarks=true
On Upgrade: shouldMergeBookmarks=false

Desktop bookmark folder still present but empty. Local bookmarks present.

Comment 5

[Emily Toop (:fluffyemily)]

Attachment: emily-on-fresh-install.log

Comment 6

[Emily Toop (:fluffyemily)]

Attachment: emily-onupgrade.log

Comment 7

[Richard Newman [:rnewman]]

f3d158c