125135 - Composer Prefs Panel: remove "pretty print" text phrase

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[robinf]

In the Composer Preferences "Composer" panel, please remove the phrase "pretty
print" from the "Reformat HTML Source" radio button.

The radio button "Reformat HTML Source" and the accompanying tooltip provide
enough information for users. I find the addition of the phrase "pretty print"
to be confusing.

Comment 1

[robinf]

Comments?

Comment 2

[Kathleen :Brade]

nsbeta1+
-->cmanske

should we be removing this option altogether (temporarily) since it is broken?

Comment 3

[Charles Manske]

Probably! I really well-formated output. I wish someone would fix this.
Akkana: who owns those output-formating rules?

Comment 4

[Akkana Peck]

It's a serializer issue, so [e-mail].  She has a bug on it,
something like "preserve source formatting doesn't work right".

Has our default for the pref, even back when we had the meaning reversed, always
been the value that will currently cause it to prettyprint?  If not, I worry a
bit about removing the option since then people who have their pref set to
"preserve" will have no obvious way of getting back.  But if that applies only
to a small set of people who downloaded nightly builds or built their own, then
it probably doesn't matter.

I vote we leave the backend pref in place even if the UI is removed, so that
preserve mode is testable and has some hope of getting fixed some day.

Comment 5

[Charles Manske]

Attachment: Fix

Comment 6

[andreww]

Comment on attachment 72103 [details] [diff] [review]
Fix

r=andreww

Comment 7

[kinmoz]

Comment on attachment 72103 [details] [diff] [review]
Fix

sr=[e-mail]

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 72103 [details] [diff] [review]
Fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Charles Manske]

checked in

Comment 10

[sujay]

verified in 3/8 build