Composer Prefs Panel: remove "pretty print" text phrase

VERIFIED FIXED in mozilla1.0

Status

VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: robinf, Assigned: cmanske)

Tracking

Trunk
mozilla1.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
In the Composer Preferences "Composer" panel, please remove the phrase "pretty
print" from the "Reformat HTML Source" radio button.

The radio button "Reformat HTML Source" and the accompanying tooltip provide
enough information for users. I find the addition of the phrase "pretty print"
to be confusing.
(Reporter)

Comment 1

17 years ago
Comments?

Comment 2

17 years ago
nsbeta1+
-->cmanske

should we be removing this option altogether (temporarily) since it is broken?
Assignee: syd → cmanske
Keywords: nsbeta1+
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Comment 3

17 years ago
Probably! I really well-formated output. I wish someone would fix this.
Akkana: who owns those output-formating rules?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0

Comment 4

17 years ago
It's a serializer issue, so tmutreja@netscape.com.  She has a bug on it,
something like "preserve source formatting doesn't work right".

Has our default for the pref, even back when we had the meaning reversed, always
been the value that will currently cause it to prettyprint?  If not, I worry a
bit about removing the option since then people who have their pref set to
"preserve" will have no obvious way of getting back.  But if that applies only
to a small set of people who downloaded nightly builds or built their own, then
it probably doesn't matter.

I vote we leave the backend pref in place even if the UI is removed, so that
preserve mode is testable and has some hope of getting fixed some day.
(Assignee)

Comment 5

17 years ago
Created attachment 72103 [details] [diff] [review]
Fix
(Assignee)

Updated

17 years ago
Keywords: patch, review
Whiteboard: FIX IN HAND, need r=,sr=

Comment 6

17 years ago
Comment on attachment 72103 [details] [diff] [review]
Fix

r=andreww
Attachment #72103 - Flags: review+
(Assignee)

Updated

17 years ago
Whiteboard: FIX IN HAND, need r=,sr= → FIX IN HAND, need sr=

Comment 7

17 years ago
Comment on attachment 72103 [details] [diff] [review]
Fix

sr=kin@netscape.com
Attachment #72103 - Flags: superreview+

Updated

17 years ago
Whiteboard: FIX IN HAND, need sr= → FIX IN HAND, reviewed

Comment 8

17 years ago
Comment on attachment 72103 [details] [diff] [review]
Fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72103 - Flags: approval+
(Assignee)

Comment 9

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND, reviewed

Comment 10

17 years ago
verified in 3/8 build
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.