1251352 - Bootstrap script ignores --no-interactive in Arch Linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Quentin Headen [:qheaden]]

When running bootstrap.py using the --no-interactive flag on Arch Linux, it does not append the correct flag to the install command to prevent prompting. It also doesn't suppress the warning prompt for AUR. This causes problems with automated install scripts that use the bootstrap.

Comment 1

[Quentin Headen [:qheaden]]

Attachment: patch-1

I've set Gregory Szorc (Build Config module owner) as the person for review. But if someone else should be the patch reviewer, feel free to change it. Also, I made this patch as a result of my having trouble building a Dockerfile using an Arch base that uses bootstrap.py to install dependencies. If there is another solution in the pipeline, and this one is useless, feel free to let me know. :)

Comment 2

[Gregory Szorc [:gps]]

This explains why Arch was hanging on a prompt in bug 1245969!

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8723700 [details] [diff] [review]
patch-1

Review of attachment 8723700 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this for you with nits addressed.

::: python/mozboot/mozboot/archlinux.py
@@ +138,5 @@
>      def pacman_install(self, *packages):
>          command = ['pacman', '-S', '--needed']
> +        if self.no_interactive:
> +            command.append('--noconfirm')
> +        command.extend(packages)

Looks like we .extend(packages) twice?

@@ +177,5 @@
>          self.run_as_root(command)
>  
>      def aur_install(self, *packages):
>          path = tempfile.mkdtemp()
> +        if self.no_interactive == False:

if not self.no_interactive:

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f2b6a81e84a0a88ad514809d8f0dd60fcdbf21a
Bug 1251352 - Respect --no-interactive during Arch bootstrap; r=gps

Comment 5

[Quentin Headen [:qheaden]]

Attachment: patch-2

Nits have been addressed in patch 2.

Comment 6

[Gregory Szorc [:gps]]

I noticed you attached a plain diff to this bug. You should either use MozReview or something like `hg bzexport` or git-moz-bz to upload patch files so the VCS metadata (such as your author information) is preserved.

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8723714 [details] [diff] [review]
patch-2

Review of attachment 8723714 [details] [diff] [review]:
-----------------------------------------------------------------

This is basically what I landed.

Comment 8

[Quentin Headen [:qheaden]]

Okay. Did you still need me to upload the diff using MozReview?

Comment 9

[Quentin Headen [:qheaden]]

Attachment: I used bzexport to generate this patch

Comment 10

[Quentin Headen [:qheaden]]

Attachment: patch-3

Fixed patch description.

Comment 11

[Gregory Szorc [:gps]]

(In reply to Quentin Headen [:qheaden] from comment #8)
> Okay. Did you still need me to upload the diff using MozReview?

No. I already landed this. See comment #4 for the link. You shouldn't need to do anything else in this bug unless the patch isn't behaving as expected.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5f2b6a81e84a