1251418 - Make test_sessionStorageBase.html work in e10s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

This test is disabled because we're not calling the event handler. I have a fix for it.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

The core difference between e10s and non-e10s is that the chrome parent for the window in non-e10s is the nsInProcessTabChildGlobal, whereas in e10s it's the nsWindowRoot. SpecialPowers.addChromeEventListener adds the event listener to the frame message manager's global.

MozSessionStorageChanged is a non-bubble only-chrome event fired on the window. That means that in the target phase in non-e10s, it fires on the nsInProcessTabChildGlobal and in e10s it fires on the nsWindowRoot (as far as I can tell, anyway). We should just use a capturing listener so that we're sure to receive the event.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8723802 [details] [diff] [review]
Patch

Yup, I realized the reason during a run last night, but you were faster :)


(I may want to change "chromeonly" dispatch a bit so that it doesn't lead to this kinds of errors, but that is a different bug.)

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbcaba9e6b76349a6cd504c9762e7ed7e4b36397
Bug 1251418 - Make test_sessionStorageBase.html work in e10s. r=smaug

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fbcaba9e6b76