Closed Bug 125145 Opened 23 years ago Closed 23 years ago

[PS] RFE: Add PR_LOG() support to PostScript print module

Categories

(Core :: Printing: Output, enhancement, P4)

Product:
Core
Component:
Printing: Output
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: roland.mainz, Assigned: roland.mainz)

References

Details

RFE: Add PR_LOG() support to the PostScript print module which is turned on even for release builds (Xprint module already has this feature and it is a great help to hunt issues on customer side) to debug issues in the field...
I'll fix this as part of bug 119491 ...
Status: NEW → ASSIGNED
Depends on: 119491
Priority: -- → P4
Target Milestone: --- → mozilla1.0
Fix in bug 126799 ...
Depends on: 126799
No longer depends on: 119491
No longer depends on: 126799
Depends on: 126799
Can you post the fix in this bug so I can review what exactly you did to implement this. And .. what does it mean to be turned on for release builds.. there will always be output for customer who print.. or only when they get errors a window will be opened for them to see technical data. I am not familiar with PR_LOG.. and what our policy if for leaving that log on for release builds.
dcone wrote: > Can you post the fix in this bug so I can review what exactly you did to > implement this. The patch you want is in bug 126799 ... > And .. what does it mean to be turned on for release builds.. > there will always be output for customer who print.. Ugh, no. See below... > or only when they get > errors a window will be opened for them to see technical data. I am not > familiar with PR_LOG... No no, there will be no output on customer side - except the customer will explicitly set the NSPR_LOG env var to a certain value ("nsDeviceContextPS:5" for the code in nsDeviceContextPS.cpp and "nsPostScriptObj:5" for the code in nsPostScriptObj.cpp. Setting |export NSPR_LOG_MODULES=nsDeviceContextPS:5,nsPostScriptObj:5| will give some usefull output. This will allow us to instruct a customer to to some "mini"-debugging on his side to provide some additional information. > and what our policy if for leaving that log on for release builds. AFAIK our policy is this: - Usage of PR_LOG() must be usefull (code in bug 126799 matches this requirement) - Code must not affect performance, e.g. do not put tons of PR_LOG() thingies into performance-critical code paths (code matches this requirement, too).
Some developer documentation for PR_LOG() is in http://lxr.mozilla.org/seamonkey/source/nsprpub/pr/include/prlog.h
Fixed by patch for bug 126799, marking bug as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Roland please verify.
Logging works, marking bug as VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.