Closed
Bug 1251482
Opened 7 years ago
Closed 7 years ago
Remove remaining references to MOZILLA_XPCOMRT_API from xpcom
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
45.21 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Now that MOZILLA_XPCOMRT_API has been retired we can remove references to it in xpcom.
19 files reference the define:
> xpcom/libxpcomrt/docs/index.rst:1
> xpcom/libxpcomrt/moz.build:1
> xpcom/glue/nsISupportsImpl.h:1
> xpcom/glue/BlockingResourceBase.cpp:3
> xpcom/base/nsDebugImpl.cpp:9
> xpcom/base/nsIMemoryReporter.idl:1
> xpcom/base/Logging.h:2
> xpcom/build/FileLocation.cpp:21
> xpcom/build/ServiceList.h:4
> xpcom/build/Services.cpp:2
> xpcom/build/FileLocation.h:6
> xpcom/threads/LazyIdleThread.cpp:4
> xpcom/threads/nsThread.cpp:20
> xpcom/threads/nsTimerImpl.cpp:1
> xpcom/components/nsCategoryManager.cpp:6
> xpcom/components/nsComponentManager.cpp:35
> xpcom/components/nsComponentManager.h:1
> xpcom/components/ManifestParser.h:2
> xpcom/ds/nsObserverService.cpp:6
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8723896 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=10bd4e1d2392
|
||
Updated•7 years ago
|
Attachment #8723896 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e33adec1aa6ad104fda36cd417d33043fe47a08 Bug 1251482 - Remove remaining references to MOZILLA_XPCOMRT_API from xpcom. r=froydnj
This and everything else from this push is backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/22424f6eeb30 for gtest failures: https://treeherder.mozilla.org/logviewer.html#?job_id=22549678&repo=mozilla-inbound
Flags: needinfo?(erahm)
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/afd1b8342a53046d3bc516ac8ae586919c0f5f88 Bug 1251482 - Remove remaining references to MOZILLA_XPCOMRT_API from xpcom. r=froydnj
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/afd1b8342a53
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(erahm)
You need to log in
before you can comment on or make changes to this bug.
Description
•