Implement IDBKeyRange.includes()

RESOLVED FIXED in Firefox 47

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

({dev-doc-complete})

unspecified
mozilla47
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: btpp-active, URL)

Attachments

(1 attachment)

Created attachment 8723910 [details] [diff] [review]
Patch

Google is on board and its in the spec, so lets do it.
Attachment #8723910 - Flags: review?(amarchesini)
Comment on attachment 8723910 [details] [diff] [review]
Patch

Review of attachment 8723910 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBKeyRange.cpp
@@ +340,5 @@
> +                      ErrorResult& aRv) const
> +{
> +  Key key;
> +  aRv = GetKeyFromJSVal(aCx, aValue, key);
> +  if (aRv.Failed()) {

NS_WARN_IF

::: testing/web-platform/tests/IndexedDB/idbkeyrange-includes.htm
@@ +3,5 @@
> +<title></title>
> +<script src=/resources/testharness.js></script>
> +<script src=/resources/testharnessreport.js></script>
> +<script>
> +  

extra spaces
Attachment #8723910 - Flags: review?(amarchesini) → review+
Whiteboard: btpp-active
(In reply to Andrea Marchesini (:baku) from comment #1)
> Comment on attachment 8723910 [details] [diff] [review]
> Patch
> 
> Review of attachment 8723910 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/indexedDB/IDBKeyRange.cpp
> @@ +340,5 @@
> > +                      ErrorResult& aRv) const
> > +{
> > +  Key key;
> > +  aRv = GetKeyFromJSVal(aCx, aValue, key);
> > +  if (aRv.Failed()) {
> 
> NS_WARN_IF

We don't do this anywhere else in this file, so I decided to ignore this.
Keywords: dev-doc-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4c0b66b8076e
https://hg.mozilla.org/mozilla-central/rev/0d0247d97108
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
I've documented includes():

https://developer.mozilla.org/en-US/docs/Web/API/IDBKeyRange
https://developer.mozilla.org/en-US/docs/Web/API/IDBKeyRange/includes

And added a note to the relevant Firefox release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/47#IndexedDB

A quick tech review would be great. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
Depends on: 1281377
You need to log in before you can comment on or make changes to this bug.