1251498 - Implement IDBKeyRange.includes()

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Google is on board and its in the spec, so lets do it.

Comment 1

[Andrea Marchesini [:baku]]

Comment on attachment 8723910 [details] [diff] [review]
Patch

Review of attachment 8723910 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBKeyRange.cpp
@@ +340,5 @@
> +                      ErrorResult& aRv) const
> +{
> +  Key key;
> +  aRv = GetKeyFromJSVal(aCx, aValue, key);
> +  if (aRv.Failed()) {

NS_WARN_IF

::: testing/web-platform/tests/IndexedDB/idbkeyrange-includes.htm
@@ +3,5 @@
> +<title></title>
> +<script src=/resources/testharness.js></script>
> +<script src=/resources/testharnessreport.js></script>
> +<script>
> +  

extra spaces

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Andrea Marchesini (:baku) from comment #1)
> Comment on attachment 8723910 [details] [diff] [review]
> Patch
> 
> Review of attachment 8723910 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/indexedDB/IDBKeyRange.cpp
> @@ +340,5 @@
> > +                      ErrorResult& aRv) const
> > +{
> > +  Key key;
> > +  aRv = GetKeyFromJSVal(aCx, aValue, key);
> > +  if (aRv.Failed()) {
> 
> NS_WARN_IF

We don't do this anywhere else in this file, so I decided to ignore this.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0b66b8076e

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d0247d97108

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c0b66b8076e
https://hg.mozilla.org/mozilla-central/rev/0d0247d97108

Comment 6

[Chris Mills [:cmills]]

I've documented includes():

https://developer.mozilla.org/en-US/docs/Web/API/IDBKeyRange
https://developer.mozilla.org/en-US/docs/Web/API/IDBKeyRange/includes

And added a note to the relevant Firefox release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/47#IndexedDB

A quick tech review would be great. Thanks!

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

lgtm, thanks!