1251542 - WebRTC ICE-TCP, TURN/TCP, TURN/TLS over HTTP proxy does not work

Status: RESOLVED WORKSFORME

(Core :: WebRTC: Networking, defect, P1)

Description

[detour]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36

Steps to reproduce:

1. Set HTTP proxy to FF 44.
2. Launch https://apprtc.appspot.com/ and join a room created by the other guy who is out of my inner network.


Actual results:

The media connection cannot be setup.


Expected results:

The media connection should be setup.

Comment 1

[detour]

By FF 44, only host candidates are gathered. By Wireshark, it is found that FF44 doesn't do ICE through my proxy. Bug 949703 is related with this. It was fixed on FF38. Tried with FF39, relay candidates are collected and the media can be setup. FF40 was tested and failed too.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

When did we switch to all-trickle?  If 39 works, and 40 fails, regression *should* be possible using Nightlies, if they're still available.  Also, the differences between those (particularly in mtransport) could be examined

Comment 3

[Byron Campen [:bwc]]

All trickle was well before this.

Comment 4

[Maire Reavy [:mreavy]]

Byron, Nils -- I'm inclined to make this a low P1 (i.e. something we want to solve in Fx48, but not necessarily uplift unless the fix is low risk and we're hearing about lots of user/developer pain).  Let me know if you disagree.

Comment 5

[Nils Ohlmeier [:drno]]

(In reply to detour from comment #1)
> By FF 44, only host candidates are gathered. By Wireshark, it is found that
> FF44 doesn't do ICE through my proxy. Bug 949703 is related with this. It
> was fixed on FF38. Tried with FF39, relay candidates are collected and the
> media can be setup. FF40 was tested and failed too.

Bug 949703 landed in 38, which means the HTTP proxy feature is in Firefox release version 38. So if gathering through your proxy still work with 38 and 39, then we are looking for something which landed in 40 which broke this.
I'll try to test this later myself.

Comment 6

[Nils Ohlmeier [:drno]]

With Firefox 47 (Nightly) it works for me. No problem.

Could I ask you to try it also with Nightly to check if the problem still exists?
If the problem still exists, could you please attach 'about:webrtc' from such a failed call?

Note: appr.tc might actually not the best candidate for testing right now, as their backup TURN server on port 3479 is down or miss-configured for quite some time already.

Comment 7

[detour]

Yes, Firefox 47 (Nightly) works.

Comment 8

[Nils Ohlmeier [:drno]]

Thanks for checking.

So some of the improvements made lately to the proxy code fixed your problem. I'm going to mark this as resolved then, as it is no longer a problem.

Comment 9

[roudakov.michael]

Firefox 48, 49 (Nightly) Win 8.1 crashes after setLocalDescription() (for example https://apprtc.appspot.com/)
SYN packet isn't sent.
TURN, TCP, proxy.

Comment 10

[Nils Ohlmeier [:drno]]

(In reply to roudakov.michael from comment #9)
> Firefox 48, 49 (Nightly) Win 8.1 crashes after setLocalDescription() (for
> example https://apprtc.appspot.com/)
> SYN packet isn't sent.
> TURN, TCP, proxy.

Could you please file a new bug for that, because this bug has been closed already and is not being worked on any more.
If you experienced a crash it would help a lot if you could after restarting Firefox open 'about:crashes' in a tab and copy the top most link in the list of crashes into the bug report.