Closed
Bug 1251605
Opened 8 years ago
Closed 6 years ago
System add-on update does not apply if firefox crashes after update and no previous restart is done
Categories
(Toolkit :: Add-ons Manager, defect, P4)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
INACTIVE
Tracking | Status | |
---|---|---|
firefox44 | --- | unaffected |
firefox45 | --- | affected |
firefox46 | --- | unaffected |
firefox47 | --- | unaffected |
firefox-esr38 | --- | unaffected |
firefox-esr45 | --- | unaffected |
People
(Reporter: bmaris, Assigned: aswan)
Details
(Whiteboard: triaged)
[Affected versions]: - Firefox 45 beta 9 build 2 [Affected platforms]: - Windows 7 64bit - Windows 10 64bit - Mac OS X 10.11.1 - Ubuntu 14.04 32bit [Steps to reproduce]: 1. Go to channel-prefs.js in Firefox installation folder and change the value of app.update.channel from 'beta' to 'beta-sysaddon' 2. Save the file and reopen Firefox 3. Visit https://addons.mozilla.org/en-US/firefox/addon/timer-fire/ and install the add-on 4. Visit http://people.mozilla.org/~tmielczarek/crashme/ and install the add-on (change 'xpinstall.signatures.required' to 'false' if add-on can't be installed) 5. Force the auto update: Tools > Fire Timer > Add-on Update 6. After the update is downloaded crash Firefox: Tools > Crash me! 7. Restart Firefox or Quit -> Start Firefox 8. Go to about:support and look for loop version [Expected result]: - Version 0.1.2 is displayed in about:support [Actual result]: - Version 0.1 is displayed in about:support [Regression range]: - Not a regression since this test update is only available in Firefox 45 beta 9 but once goes live it will impact Firefox 45. [Additional notes]: - If step 5 is run again and after the update the user restarts Firefox, the update will be successfully applied (version 0.1.2) - I don't consider this blocker since is unlikely that Firefox will crash again after the second update is applied, but should be looked at.
Comment 1•8 years ago
|
||
This code is in Toolkit, so moving to what I think is the right place.
Component: Client → Application Update
Product: Hello (Loop) → Toolkit
Comment 2•8 years ago
|
||
We would need to flush prefs to disk after installing the update to survive the crash. As long as we remain in a consistent state I'm less concerned though.
Component: Application Update → Add-ons Manager
Reporter | ||
Updated•8 years ago
|
status-firefox44:
--- → unaffected
status-firefox46:
--- → unaffected
status-firefox47:
--- → unaffected
status-firefox-esr38:
--- → unaffected
status-firefox-esr45:
--- → unaffected
Reporter | ||
Comment 3•8 years ago
|
||
Updated the tracking flags based on comment 0 (Only Firefox 45 is affected).
Comment 4•8 years ago
|
||
Specifically we should call Services.prefs.savePrefFile(null) after we do the system add-on update. I bet you could do this Andrew!
Flags: needinfo?(aswan)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aswan
Flags: needinfo?(aswan)
Updated•8 years ago
|
Priority: -- → P4
Whiteboard: triaged
Comment 5•8 years ago
|
||
Altering title, as I expect this still applies to other system add-ons.
Summary: Hello update does not apply if firefox crashes after update and no previous restart is done → System add-on update does not apply if firefox crashes after update and no previous restart is done
Comment 6•6 years ago
|
||
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•