System add-on update does not apply if firefox crashes after update and no previous restart is done




3 years ago
3 months ago


(Reporter: bogdan_maris, Assigned: aswan)



Firefox Tracking Flags

(firefox44 unaffected, firefox45 affected, firefox46 unaffected, firefox47 unaffected, firefox-esr38 unaffected, firefox-esr45 unaffected)


(Whiteboard: triaged)

[Affected versions]:
- Firefox 45 beta 9 build 2

[Affected platforms]:
- Windows 7 64bit
- Windows 10 64bit
- Mac OS X 10.11.1
- Ubuntu 14.04 32bit

[Steps to reproduce]:
1. Go to channel-prefs.js in Firefox installation folder and change the value of from 'beta' to 'beta-sysaddon'
2. Save the file and reopen Firefox
3. Visit and install the add-on
4. Visit and install the add-on (change 'xpinstall.signatures.required' to 'false' if add-on can't be installed)
5. Force the auto update: Tools > Fire Timer > Add-on Update
6. After the update is downloaded crash Firefox: Tools > Crash me!
7. Restart Firefox or Quit -> Start Firefox
8. Go to about:support and look for loop version

[Expected result]:
- Version 0.1.2 is displayed in about:support

[Actual result]:
- Version 0.1 is displayed in about:support

[Regression range]:
- Not a regression since this test update is only available in Firefox 45 beta 9 but once goes live it will impact Firefox 45.

[Additional notes]:
- If step 5 is run again and after the update the user restarts Firefox, the update will be successfully applied (version 0.1.2)
- I don't consider this blocker since is unlikely that Firefox will crash again after the second update is applied, but should be looked at.
This code is in Toolkit, so moving to what I think is the right place.
Component: Client → Application Update
Product: Hello (Loop) → Toolkit
We would need to flush prefs to disk after installing the update to survive the crash. As long as we remain in a consistent state I'm less concerned though.
Component: Application Update → Add-ons Manager
status-firefox44: --- → unaffected
status-firefox46: --- → unaffected
status-firefox47: --- → unaffected
status-firefox-esr38: --- → unaffected
status-firefox-esr45: --- → unaffected
Updated the tracking flags based on comment 0 (Only Firefox 45 is affected).
Specifically we should call Services.prefs.savePrefFile(null) after we do the system add-on update.

I bet you could do this Andrew!
Flags: needinfo?(aswan)
Assignee: nobody → aswan
Flags: needinfo?(aswan)


2 years ago
Priority: -- → P4
Whiteboard: triaged
Altering title, as I expect this still applies to other system add-ons.
Summary: Hello update does not apply if firefox crashes after update and no previous restart is done → System add-on update does not apply if firefox crashes after update and no previous restart is done

Comment 6

3 months ago
Per policy at If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Last Resolved: 3 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.