1251703 - Always resolve virtual calls to known callees

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

Currently, most of nsISupports subclasses' virtual methods are assumed to be overridable, either via script or binary extensions. The way this is implemented is to check for the overridable cases and avoid resolving the methods to all possible virtual definitions.

This is fine for the GC hazard analysis, but makes the callgraph less useful for other purposes (including just exploratory investigation) since it doesn't include any of these edges.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Always resolve virtual calls to known callees

Instead, resolve all virtual calls and emit edges for them into the callgraph, but just emit the "unknown field call" marker in the nsISupports cases. (Also suppress the "fully-resolved virtual" token in this case, not that anything is looking at that right now.)

mccr8: congrats, I get to inflict reviews upon you now. :-)

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fccf01d7567d

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fccf01d7567d