1251734 - Fix jetpack definitions

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Armen [:armenzg]]

I've noticed some inconsistencies with the jetpack definitions.

Comment 1

[Armen [:armenzg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e7ab49dc5c4

Comment 2

[Armen [:armenzg]]

Attachment: jetpack.diff

Comment 3

[Armen [:armenzg]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f282f0355f9e5b5c6f806b02405412bd2ee11690
Bug 1251734 - Fix TC jetpack definition inconsistencies. r=jmaher

Comment 4

[Armen [:armenzg]]

Attachment: increase timeout

I've noticed that it is one of the offenders for the 3600 seconds time out bug.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8724852 [details] [diff] [review]
increase timeout

Review of attachment 8724852 [details] [diff] [review]:
-----------------------------------------------------------------

good find

Comment 6

[Armen [:armenzg]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95703fdc2175444a69dfb154f7d1bad74f19cf79
Bug 1251734 - Increase TC Linux64 jetpack timeout. DONTBUILD. r=jmaher

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f282f0355f9e
https://hg.mozilla.org/mozilla-central/rev/95703fdc2175

Comment 8

[Pete Moore [:pmoore][:pete]]

Moving closed bugs across to new Bugzilla product "TaskCluster".

Comment 9

[Armen [:armenzg]]

Attachment: include two aliases for jetpack

I totally thought I had landed this patch but it seems I didn't!

This allows for this syntax:
* -u jetpack
* -u mochitest-jetpack

In general, jetpack would already trigger with this:
* -u all
* -u mochitest

Comment 10

[Armen [:armenzg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b99156a09ba2

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8726714 [details] [diff] [review]
include two aliases for jetpack

Review of attachment 8726714 [details] [diff] [review]:
-----------------------------------------------------------------

is there a chance that we would run two jetpacks on a push?  Do we really need to have this support 'jetpack' and 'mochitest-jetpack'?

Comment 12

[Armen [:armenzg]]

It won't schedule it twice [1]

I don't need the 'jetpack' alias. In my mind, I keep using 'jetpack' even though it is wrong syntax.
I'm happy to drop it.

What do you say?


[1] armenzg@armenzg-thinkpad:~/repos/mozilla-central$ ./mach taskcluster-graph --pushlog-id=112616 --project=try '--message=try: -b d -p linux64 -u jetpack,mochitest -t none' --owner=[e-mail] --level=1 --revision-hash=f016aa05b5c6f7864e97d638b71eba088f8ef899 --extend-graph | grep "jetpack" | grep "TC"
cannot query vcs info because vcs info not provided
                    "name": "[TC] Linux64 mochitest-jetpack",

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

lets drop jetpack, if it is mochitest-jetpack, lets make it more specific.

Comment 14

[Armen [:armenzg]]

Attachment: include try syntax alias for Jetpack

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8726898 [details] [diff] [review]
include try syntax alias for Jetpack

Review of attachment 8726898 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 16

[Armen [:armenzg]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb913717b2f5e9cb21e1dbb256776afdeaac4712
Bug 1251734 - Add try syntax alias for jetpack. DONTBUILD. CLOSED TREE. r=jmaher

Comment 17

[Armen [:armenzg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=789b44958727

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb913717b2f5