Fix jetpack definitions

RESOLVED FIXED in mozilla46

Status

Taskcluster
Integration
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: armenzg, Assigned: armenzg)

Tracking

unspecified
mozilla46

Details

Attachments

(3 attachments, 1 obsolete attachment)

I've noticed some inconsistencies with the jetpack definitions.
Created attachment 8724732 [details] [diff] [review]
jetpack.diff
Attachment #8724732 - Flags: review?(jmaher)
Attachment #8724732 - Flags: review?(jmaher) → review+
Created attachment 8724852 [details] [diff] [review]
increase timeout

I've noticed that it is one of the offenders for the 3600 seconds time out bug.
Attachment #8724852 - Flags: review?(jmaher)
Comment on attachment 8724852 [details] [diff] [review]
increase timeout

Review of attachment 8724852 [details] [diff] [review]:
-----------------------------------------------------------------

good find
Attachment #8724852 - Flags: review?(jmaher) → review+

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f282f0355f9e
https://hg.mozilla.org/mozilla-central/rev/95703fdc2175
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Moving closed bugs across to new Bugzilla product "TaskCluster".
status-firefox47: fixed → ---
Component: TaskCluster → Integration
Product: Testing → Taskcluster
Target Milestone: mozilla47 → mozilla46
Created attachment 8726714 [details] [diff] [review]
include two aliases for jetpack

I totally thought I had landed this patch but it seems I didn't!

This allows for this syntax:
* -u jetpack
* -u mochitest-jetpack

In general, jetpack would already trigger with this:
* -u all
* -u mochitest
Attachment #8726714 - Flags: review?(jmaher)
Comment on attachment 8726714 [details] [diff] [review]
include two aliases for jetpack

Review of attachment 8726714 [details] [diff] [review]:
-----------------------------------------------------------------

is there a chance that we would run two jetpacks on a push?  Do we really need to have this support 'jetpack' and 'mochitest-jetpack'?
It won't schedule it twice [1]

I don't need the 'jetpack' alias. In my mind, I keep using 'jetpack' even though it is wrong syntax.
I'm happy to drop it.

What do you say?


[1] armenzg@armenzg-thinkpad:~/repos/mozilla-central$ ./mach taskcluster-graph --pushlog-id=112616 --project=try '--message=try: -b d -p linux64 -u jetpack,mochitest -t none' --owner=armenzg@mozilla.com --level=1 --revision-hash=f016aa05b5c6f7864e97d638b71eba088f8ef899 --extend-graph | grep "jetpack" | grep "TC"
cannot query vcs info because vcs info not provided
                    "name": "[TC] Linux64 mochitest-jetpack",
Flags: needinfo?(jmaher)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
lets drop jetpack, if it is mochitest-jetpack, lets make it more specific.
Flags: needinfo?(jmaher)
Created attachment 8726898 [details] [diff] [review]
include try syntax alias for Jetpack
Attachment #8726714 - Attachment is obsolete: true
Attachment #8726714 - Flags: review?(jmaher)
Attachment #8726898 - Flags: review?(jmaher)
Comment on attachment 8726898 [details] [diff] [review]
include try syntax alias for Jetpack

Review of attachment 8726898 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8726898 - Flags: review?(jmaher) → review+

Comment 18

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fb913717b2f5
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.