1251740 - (SearchEngineRow) java.util.ConcurrentModificationException

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Currently my Nightly is crashing every time I type into the URL bar.

Stack trace:

> GeckoCrashHandler  E  >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
>                    E  java.util.ConcurrentModificationException
>                    E      at java.util.ArrayList$ArrayListIterator.next(ArrayList.java:573)
>                    E      at org.mozilla.gecko.home.SearchEngineRow.updateSuggestions(SearchEngineRow.java:392)
>                    E      at org.mozilla.gecko.home.BrowserSearch$SearchAdapter.bindView(BrowserSearch.java:1096)
>                    E      at org.mozilla.gecko.home.MultiTypeCursorAdapter.getView(MultiTypeCursorAdapter.java:62)
>                    E      at android.widget.AbsListView.obtainView(AbsListView.java:2346)
>                    E      at android.widget.ListView.makeAndAddView(ListView.java:1876)
>                    E      at android.widget.ListView.fillSpecific(ListView.java:1355)
>                    E      at android.widget.ListView.layoutChildren(ListView.java:1663)
>                    E      at android.widget.AbsListView.onLayout(AbsListView.java:2148)
>                    E      at android.view.View.layout(View.java:16636)

Crash report:
https://crash-stats.mozilla.com/report/index/3280ab94-9bf6-4947-9fe5-e42532160226

Comment 1

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1251740 - Rename searchistory to searchHistory r=me

Review commit: https://reviewboard.mozilla.org/r/36937/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36937/

Comment 2

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1251740 - Remove ArrayList item using iterator instead of from list when iterating r=sebastian

Otherwise we will crash with a java.util.ConcurrentModificationException on iterator.next()
after removing an item using list.remove(item).

Review commit: https://reviewboard.mozilla.org/r/36939/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36939/

Comment 3

[Andrzej Hunt :ahunt]

Caused by the commit in Bug 1236387.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8724249 [details]
MozReview Request: Bug 1251740 - Remove ArrayList item using iterator instead of from list when iterating r=sebastian

https://reviewboard.mozilla.org/r/36939/#review33555

Comment 5

[Andrzej Hunt :ahunt]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2d43cfb9474

Comment 6

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/b54aa19a214e828357cfbbd98999df32ef0bb6df
Bug 1251740 - Rename searchistory to searchHistory r=me

https://hg.mozilla.org/integration/fx-team/rev/8871ed7e17bc5022f865206fc34222aed72ed103
Bug 1251740 - Remove ArrayList item using iterator instead of from list when iterating r=sebastian

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b54aa19a214e
https://hg.mozilla.org/mozilla-central/rev/8871ed7e17bc