Closed Bug 1251753 Opened 8 years ago Closed 8 years ago

Floating scrollbars in devtools become invisible on dark theme if I select text

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox47 affected)

Status:
RESOLVED DUPLICATE of bug 1100622
Tracking Flags:
Tracking Status
firefox47 --- affected

People

(Reporter: arni2033, Unassigned)

References

(
URL
)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

screenshot 1 - Floating scrollbars in devtools become invisible.png
59.92 KB, image/png
Details 
>>>   My Info:   Win7_64, Nightly 47, 32bit, ID 20160225030209
STR:
1. Open the following "data:" url or click URL in the form above
>   data:text/html,<body><script>var s1=''; for (i=0;i<999;i++) s1+='\n'; var s2=''; for (i=0;i<999;i++) s2+='T_'; document.body.innerHTML="<style>"+s1+"/*"+s2+"*/</style>"; </script>
2. Open Style Editor (Shift+F7), click in the code area to focus it
3. Press Ctrl+A to select all text

AR:  Floating scrollbars become invisible
ER:  Scrollbars should be visible

Note:  I'm attaching a screenshot taken on different page, but it shows the issue.
Looks like it's not truly invisible, just extremely low contrast against the selection color.

I am not sure how much we can do to avoid this, but let's check with UX.
Flags: needinfo?(hholmes)
Priority: -- → P3
Whiteboard: [btpp-backlog]
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> I am not sure how much we can do to avoid this
Like all similar problems? To keep scrollbar transparent-white and add 1px black border.
That's a suggestion.
We're currently implementing what the OS does natively, so this seems more like an Apple problem than a developer tools problem.

If someone disagrees, we can re-open the bug and discuss it further.
Flags: needinfo?(hholmes)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
(In reply to Helen V. Holmes (:helenvholmes) (:✨) from comment #3)
> We're currently implementing what the OS does natively, so this seems more like an Apple problem
Again, how Apple issues are related to my issue on Win7? (comment 0)
Did you mean that somebody failed to implement correctly what Win7 does natively with scrollbars?
(In reply to arni2033 from comment #4)
> (In reply to Helen V. Holmes (:helenvholmes) (:✨) from comment #3)
> > We're currently implementing what the OS does natively, so this seems more like an Apple problem
> Again, how Apple issues are related to my issue on Win7? (comment 0)
> Did you mean that somebody failed to implement correctly what Win7 does
> natively with scrollbars?

DevTools uses an OS X-like floating scrollbar on all OSes with the dark theme.
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> DevTools uses an OS X-like floating scrollbar
I see now. Some of Firefox developers liked Mac scrollbars and decided to implement _similar_ thing

This is why argument "this seems more like an Apple problem" is invalid:
1) I saw two types of "floating" scrollbars on Mac.
    1st type is always visible, and preserves space under itself
    2nd type only appears when you scroll, and does not preserve any space
    https://www.youtube.com/watch?v=tYqS7vgiTLU
    Devtools scrollbars of dark theme in Firefox don't belong to any of those types. It's different
2) You can't just take some knowingly bad design and blame its author for bugs.
    Of course we can say that all Firefox developers liked the design,.. but they didn't tested it.
    The design is really buggy, I can _show_ it. Some issues are specific to Firefox. Actually, I
    believe that some people understood that design is bad, so they made adjustment (1), or, should
    I say "haven't implemented hide-on-blur feature"? What I suggest is just to continue their work

If any of you are so confident that it's Apple's fault (that I have such issues on Win7 (sic)),
please mark as Wontfix bug 1197229 and a bug about those scrollbars which I'll file tomorrow
(I can even set NI for this purpose)
(In reply to arni2033 from comment #6)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> > DevTools uses an OS X-like floating scrollbar
> I see now. Some of Firefox developers liked Mac scrollbars and decided to
> implement _similar_ thing
> 
> This is why argument "this seems more like an Apple problem" is invalid:
> 1) I saw two types of "floating" scrollbars on Mac.
>     1st type is always visible, and preserves space under itself
>     2nd type only appears when you scroll, and does not preserve any space
>     https://www.youtube.com/watch?v=tYqS7vgiTLU
>     Devtools scrollbars of dark theme in Firefox don't belong to any of
> those types. It's different

Yes, all of the statements are true.  The DevTools floating scrollbars are a custom thing that is similar to OS X native floating scrollbars, but not identical. 

> 2) You can't just take some knowingly bad design and blame its author for
> bugs.
>     Of course we can say that all Firefox developers liked the design,.. but
> they didn't tested it.
>     The design is really buggy, I can _show_ it. Some issues are specific to
> Firefox. Actually, I
>     believe that some people understood that design is bad, so they made
> adjustment (1), or, should
>     I say "haven't implemented hide-on-blur feature"? What I suggest is just
> to continue their work

These are more opinions about the design that could be debated one way or another.

Helen's comment 3 isn't quite right, since we are only simulating something from OS X, we aren't reusing the implementation, so it is different Apple's version, you're right.

I think the main reason we closed this bug is that we don't believe we need to make a change for this specific issue at this time, and we do not plan to do so in future given what we know at the moment.  If our plans change, then the bug can be reopened.
Resolution: WONTFIX → DUPLICATE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: