Add pref to filter chrome:// errors in JS Console

VERIFIED FIXED in mozilla1.0

Status

Core Graveyard
Error Console
VERIFIED FIXED
16 years ago
7 years ago

People

(Reporter: bc, Assigned: Blake Ross)

Tracking

Trunk
mozilla1.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

4.71 KB, patch
Ben Goodger (use ben at mozilla dot org for email)
: review+
Joe Hewitt (gone)
: superreview+
Details | Diff | Splinter Review
15.00 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
Internal JavaScript errors are reported to the JS Console using urls of the form
chrome://xxx, e.g.

Error: redeclaration of const hide
Source File: chrome://wallet/content/walletOverlay.js
Line: 1

These errors can be filtered in the JS Console based upon the chrome:// protocol.

These errors are useful for Mozilla developers to find and correct JavaScript
errors however they are not useful for Web Developers who are not concerned with
the internals of Mozilla.

These internal errors in the JS console are an embarrassment when attempting to
teach Web Developers how to use the JS Console to debug their JavaScript.

Of course the best solution would be to not have internal JS errors at all, but
that is not likely.

There would not necessarily need to be a UI for this pref.

Comment 1

16 years ago
I agree. We should do this.
Severity: enhancement → normal
Keywords: nsbeta1
(Assignee)

Comment 2

16 years ago
I would prefer to see us not do any work at all to report our errors if it's a
release build, rather than filtering out at the last possible moment.  But I
wonder if this info is useful for tech support, in which case having a way to
turn them on would be useful.
These errors are incredibly helpful in nightlys if nothing else....  Having a
way for bug reporters to be able to provide that information would be good.
(Assignee)

Comment 4

16 years ago
Oh, definitely. We should probably have them on in milestones, too.  We should
provide an easy way for distributors to turn them off, though.

Comment 5

16 years ago
Hiding the bugs under the carpet won't make them go away. I would find it more
embarrassing to hide them than to have them to begin with.

Oh yeah, and not being able to hide them is an extra incentive to fix ;-)
(Reporter)

Comment 6

16 years ago
What is embarrassing is trying to teach someone to use the JavaScript Console to
determine why their web page is not being displayed properly and have to teach
them to ignore the multitude of internal errors to find the relevant errors for
their web page. 

This is not intended to sweep anything under the rug, but is intended to make
supporting commercial releases of the browser easier.  

Of course these bugs should be fixed, and I heartily invite any and all to do
just that. But I get enough denigrating comments from users without having to
deal with this cruft that no one else seems to care about. 

I *need* a simple and clear mechanism to communicate errors in JavaScript to end
users and web developers who do not want to debug Mozilla.
I couldn't agree more with Bob.

Comment 8

16 years ago
nsbeta1+ per Nav triage team.  
Keywords: nsbeta1 → nsbeta1+

Comment 9

16 years ago
Mass move of nsbeta1+ bugs that didn't have a valid MachV milestone to mozilla1.0.
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 10

16 years ago
-> me
Assignee: hewitt → blaker
(Assignee)

Comment 11

16 years ago
Created attachment 71244 [details] [diff] [review]
patch

Comment 12

16 years ago
Comment on attachment 71244 [details] [diff] [review]
patch

sr=hewitt
Attachment #71244 - Flags: superreview+
Comment on attachment 71244 [details] [diff] [review]
patch

r=ben@netscape.com with the 'from chrome' (or similar) text change we discussed
on IRC.
Attachment #71244 - Flags: review+

Comment 14

16 years ago
a=asa (on behalf of drivers) for checkin to 0.9.9
(Assignee)

Comment 15

16 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 16

16 years ago
small bug. JavaScript is not spelled "Javascript". It "JavaScript". With 
capital S

Comment 17

16 years ago
Created attachment 71656 [details] [diff] [review]
patch to fix spelling

The patch does 3 things:

1. Fixes "JavaScript" spelling in pref-debug.dtd
Tested by visually observing debug pane.

2. Renames debugStrictJavascript.label and debugConsoleJavascript.label to
debugStrictJavaScript.label and debugConsoleJavaScript.label inside
pref-debug.dtd and pref-debug.xul
Tested by visually observing debug pane as well as searching LXR for any files
that refer to debugStrictJavascript.label

3. Cleans out 434 trailing whitespaces inside pref-debug.xul and
consoleBindings.xml
Tested by reviewing the lines that patch modifies. As well as visually checking
every pref Category with the cleaned files. And checking JS Console during it.
(Yes I have no life)

Comment 18

16 years ago
reopening, review please
Status: RESOLVED → REOPENED
Keywords: review
Resolution: FIXED → ---
(Assignee)

Comment 19

16 years ago
Please file a new bug for nits...thanks.  The capitalized S does not need to be
fixed. This is debug UI!!
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED

Comment 20

15 years ago
verified.
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey

Updated

7 years ago
Component: Error Console → Error Console
Product: SeaMonkey → Core Graveyard
You need to log in before you can comment on or make changes to this bug.