1251842 - Content of "Synced Tabs" panel is placed at the top of long panel, so there's too much space at the bottom

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P3)

Description

[arni2033]

Attachment: screenshot 1 - there's too much space at the bottom of 'Synced Tabs' panel.png

>>>   My Info:   Win7_64, Nightly 47, 32bit, ID 20160225030209
STR:
1. Launch new profile
2. Move "Synced Tabs" button to toolbar
3. Click "Synced Tabs" button

AR:  Content is aligned quite badly, too much space at the bottom
ER:  Content should be centered, OR the panel height should be equal to the height of content, OR at least like on previous versions

There're 2 regressions:
1) Bug 1238566. "Synced Tabs" panel's content jumped to top by ~10px
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=2cb984c700cba60cc93c51a39a525276987e49e5&tochange=be005c69fbb61cfb10e544c0a6a0b9d5e6193a81

2) Bug 1236372. "Synced Tabs" panel has increased its height from 360px to 396px
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ea39d4a6232c278dd8d805608a07cf9f4cc4c76b&tochange=fb7ceaf4b009243423cdaf1077adbb6c609b22e5

Comment 1

[arni2033]

Attachment: screenshot 2 - old appearance was not so bad.png

Maybe it was reported earlier without mentioning bug 1238566 and bug 1236372, because, to be honest,
content in that panel wasn't _completely_ centered even before those bugs. But now it's really bad

Comment 2

[Mark Hammond [:markh] [:mhammond]]

We increased the size as it was too small in some locales. The correct fix here is one of the 2 bugs I've marked as blocking this.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Also, dropping bug 1238566 from here as that was about horizontal centering rather than vertical.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

I think everyone is happy with the layout now those other bugs are fixed.