Closed Bug 1251887 Opened 4 years ago Closed 4 years ago

Add break to unintentional switch fallthrough in GfxInfoBase.cpp to fix -Wimplicit-fallthrough warning

Categories

(Core :: Canvas: 2D, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file, 1 obsolete file)

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional, but in this case, a break is enough.

widget/GfxInfoBase.cpp:158:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8724474 - Attachment is obsolete: true
Attachment #8724475 - Flags: review?(milan)
Attachment #8724475 - Flags: review?(milan) → review+
Thanks, Milan!
https://hg.mozilla.org/mozilla-central/rev/65f7f2ffd30c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.