If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add break to unintentional switch fallthrough in GfxInfoBase.cpp to fix -Wimplicit-fallthrough warning

RESOLVED FIXED in Firefox 47

Status

()

Core
Canvas: 2D
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (obsolete)
(Assignee)

Comment 1

2 years ago
Created attachment 8724475 [details] [diff] [review]
GfxInfoBase_Wimplicit-fallthrough.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional, but in this case, a break is enough.

widget/GfxInfoBase.cpp:158:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8724474 - Attachment is obsolete: true
Attachment #8724475 - Flags: review?(milan)
Attachment #8724475 - Flags: review?(milan) → review+
(Assignee)

Comment 2

2 years ago
Thanks, Milan!
status-firefox47: --- → affected

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/65f7f2ffd30c

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/65f7f2ffd30c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Assignee)

Updated

2 years ago
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.