1251933 - Going from private to normal browsing in tab tray and close the last tab will open private browsing (landscape)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Winson Wen]

User Agent: Mozilla/5.0 (Android 6.0.1; Mobile; rv:45.0) Gecko/45.0 Firefox/45.0
Build ID: 20160222141705

Steps to reproduce:

Have the Firefox home page open as the only tab
Open a new private tab
Attempt to close the tab with Firefox home page


Actual results:

When in portrait, tab closes successfully
In landscape, tab reopens.


Expected results:

Tab closes successfully in both cases.
Since this only fails in landscape, it could be related to the grid layout of tabs when in landscape. Not reproducible on tablet.

Comment 1

[Winson Wen]

Works correctly in Firefox Android 43, broken in 44 onward.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

Steps:
- set homepage to google.com 
- restart Firefox to have one tab in normal browsing with it
- open a private tab opened
- open the tab tray
- switch to normal browsing by tapping the icon
- swipe to close the tab from normal browsing.
=> in portrait: The tab from private browsing is restored and displayed. If i open the tab tray and go to normal browsing, the tab tray is empty: http://i.imgur.com/8mmjZUS.jpg
=> in landscape: after I swipe to close the tab from normal browsing, about:home is displayed

Is this what you see?

Comment 3

[Winson Wen]

Yes, that's what I see, though I don't think setting the homepage to google.com is necessary to reproduce.

Comment 4

[Teodora Vermesan (:TeoVermesan)]

This is a regression. I've installed on older build. 19-10-2015 Nightly build. Opened a tab in normal browsing, one in private browsing, switched to normal browsing by tapping the icon and then closed the tab from normal browsing. about:home is displayed in normal browsing. This works ok in portrait and landscape. Then I've installed 20-10-2015 Nightly build. After closing the tab from normal browsing, the tab from private browsing is restored and displayed and the tab tray is empty for normal browsing.

Here is the pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1a157155a4fe0074b3d03b54fe9e466472c2cd56&tochange=f7b746b4e91307448cb0746a41f677bfc23908b0

Is Bug 1214602 the cause?

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Didn't mean to clear the NI. Need to investigate first before I can comment.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Okay, yeah, I can reproduce it.

To summarize: After the STR:
* In landscape closing the last "normal" tab will show about:home
* In portrait closing the last "normal" tab will show the (selected) private tab

At some point I really should continue to work on bug 1116415 - this will unify the list/grid implementation by using a RecyclerView. Currently we have two implementations (grid vs. list). They behave a bit differently and have some duplicated code.

TabsGridLayout handling close:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/tabs/TabsGridLayout.java#217-246

TabsListLayout handling close:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/tabs/TabsListLayout.java#119-126

I'll wait until after triage today to see how important this is.

Comment 7

[:Margaret Leibovic]

This is low priority because it only affects landscape on phones, but it would be good to fix it. Is it possible to write a quick fix?

You could nominate the RecyclerView work in the funnel meeting, since that's a larger project, but would be good for paying down some technical debt in this area.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.