Open Bug 1252002 Opened 9 years ago Updated 2 years ago

[css-grid] Avoid copying the mCols / mRows elements from SharedGridData to GridReflowState for continuations

Categories

(Core :: Layout: Grid, defect, P4)

defect

Tracking

()

People

(Reporter: MatsPalmgren_bugz, Unassigned)

References

Details

(Keywords: perf)

Follow-up from bug 1144096 comment 36:

dholbert> Why do we need to make our own private copy of the mCols & mRows arrays here
dholbert> (distinct from the shared data)?

Because we don't have shared data for the first-in-flow (and won't create
it unless it's needed).  I guess we could swap the array elements while
reflowing continuations and then swap them back after we're done.  I'll
have to review the code to see if that's possible (i.e. that all changes
done to the GridReflowState copy is what we want to share).
I've added a XXX comment for now.  I'll address this in a follow-up bug.

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: MatsPalmgren_bugz → nobody
Severity: minor → S4
Component: Layout → Layout: Grid
You need to log in before you can comment on or make changes to this bug.