1252039 - [Static Analysis][Operands don't affect result] In function SeparatorRequiredBetweenTokens

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that in the following context:

>>    default:
>>      MOZ_ASSERT(aToken1 == eCSSTokenSerialization_Nothing ||
>>                 aToken1 == eCSSTokenSerialization_Whitespace ||
>>                 aToken1 == eCSSTokenSerialization_Percentage ||
>>                 aToken1 == eCSSTokenSerialization_URL_or_BadURL ||
>>                 aToken1 == eCSSTokenSerialization_Function ||
>>                 aToken1 == eCSSTokenSerialization_CDC ||
>>                 aToken1 == eCSSTokenSerialization_Symbol_OpenParen ||
>>                 aToken1 == eCSSTokenSerialization_Symbol_Question ||
>>                 aToken1 == eCSSTokenSerialization_Symbol_Assorted ||
>>                 aToken1 == eCSSTokenSerialization_Symbol_Asterisk ||
>>                 aToken1 == eCSSTokenSerialization_Symbol_Equals ||
>>                 aToken1 == eCSSTokenSerialization_Symbol_Bar ||
>>                 aToken1 == eCSSTokenSerialization_Symbol_Slash ||
>>                 aToken1 == eCSSTokenSerialization_Other ||
>>                 "unexpected nsCSSTokenSerializationType value");
>>      return false;

operands don't affect the result since |"unexpected nsCSSTokenSerializationType value"| will always translate to a valid memory address thus the MOZ_ASSERT becoming useless.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1252039 - corrected MOZ_ASSERT expression in SeparatorRequiredBetweenTokens. r?roc

Review commit: https://reviewboard.mozilla.org/r/37115/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37115/

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8724678 [details]
MozReview Request: Bug 1252039 - corrected MOZ_ASSERT expression in SeparatorRequiredBetweenTokens. r?roc

https://reviewboard.mozilla.org/r/37115/#review33665

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be813aef3471

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be813aef3471