1252054 - [Sync Tabs Sidebar] Order of devices and tabs from sidebar is not the same as order of devices and tabs from Synced Tabs panel

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Liviu Cirdei]

Attachment: synced devices-tabs order.png

[Affected versions]: 47.0a1 
Build ID 	20160228030239
Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0

[Affected OS]: all 

Steps to reproduce:

1. On a first device sign in to Sync with a Firefox account.
2. Open some tabs and perform a sync.
3. On a second device sign in to Sync with the same Firefox account.
4. Open some tabs and perform a sync.
5. On a third device (PC) sign in with the same account and open the synced tabs panel. (Menu > Synced Tabs).
6. On third device open synced tabs sidebar. (Menu bar > View > Sidebar >Synced Tabs).
7. Compare the order of devices and tabs from Synced Tabs panel and Synced Tabs sidebar.

[Actual results]: 
The order of devices and synced tabs from sidebar is not the same as the order from synced tabs panel. See attached screenshot and compare the orders of devices and tabs.

[Expected results]:
Order of devices and tabs should be the same on synced tabs sidebar as on synced tabs panel.

[Additional notes]: 
- On sidebar first synced device is placed on top of the list and last synced device at the bottom, while on synced tabs panel last synced device is placed on top of the list and first synced device on bottom. 
- On synced tabs panel the last synced device is always moved to top of the list, but on sidebar the device remain on the same position as it was when first synced.

Comment 1

[Lina Butler [:lina]]

Attachment: Screen Shot 2016-03-07 at 1.08.31 PM.png

Some quick sleuthing: I can consistently reproduce the devices out of order issue, but not the tabs. :ckarlof showed me both occur on his profile, so there's likely something else at play. I'll focus on devices for now, and that might uncover the tabs issue, too.

Comment 2

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1252054 - Sort "Synced Tabs" sidebar entries by last used date. r?markh

Review commit: https://reviewboard.mozilla.org/r/38561/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38561/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8727637 [details]
MozReview Request: Bug 1252054 - Sort "Synced Tabs" sidebar entries by last used date. r?markh

https://reviewboard.mozilla.org/r/38561/#review35201

Looks great, thanks.

Comment 4

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70fe80f3058f

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d6b4d2cbe5de

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6b4d2cbe5de

Comment 7

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OS X 10.9.5 using latest Nightly 48.0a1 (buildID: 20160413030239) - the order of devices and tabs is the same on Synced Tabs Sidebar as on Synced Tabs Panel.