Closed
Bug 1252070
Opened 9 years ago
Closed 9 years ago
Don't prompt to 'Re-enter passcode' when turning passcode off
Categories
(Firefox for iOS :: Login Management, defect)
Tracking
()
VERIFIED
FIXED
4.0
People
(Reporter: csuciu, Unassigned)
References
Details
When turning passcode off, the user should not be asked to confirm (re-enter) the passcode
Updated•9 years ago
|
Rank: 5
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Comment 1•9 years ago
|
||
To clarify, the current behavior is that we have to enter the passcode *twice* when turning it off. That's not the behavior we want is it? It makes sense when setting a passcode to make sure they don't mistype, but requiring the user to enter it twice after it's already set just gets in the way.
Flags: needinfo?(sleroux)
Flags: needinfo?(randersen)
Comment 2•9 years ago
|
||
As discussed in triage the pattern we want to do here is an enter/confirm flow to double check the user is entering the passcode before turning it off.
Flags: needinfo?(sleroux)
Comment 3•9 years ago
|
||
(In reply to Stephan Leroux [:sleroux] from comment #2)
> As discussed in triage the pattern we want to do here is an enter/confirm
> flow to double check the user is entering the passcode before turning it off.
Yeah, but I think there was some confusion about what this bug meant. If we read this as "require the passcode when turning it off", I think we all agree this is INVALID. But what it really means is "require entering the passcode *twice* when turning it off", and I'd argue that we don't want to do that.
It's a common UX pattern to require passcode reentry when setting the password. If I want to set the passcode to 1234, for example, and I accidentally type 1235, the confirm screen will catch the password mismatch and the passcode won't change (unless I mistype it the same way twice, which is rare). The system doesn't know what passcode I really want, so having the confirm screen is a standard way to account for human error.
If the passcode is already set, though, the usage above doesn't apply. In this case, I have 1) already chosen to turn off the passcode, and 2) confirmed my choice by entering my existing passcode. There's no reason to retype it: the system already knows what the passcode is, and I've confirmed my choice by entering it.
Comment 4•9 years ago
|
||
> It's a common UX pattern to require passcode reentry when setting the
> password. If I want to set the passcode to 1234, for example, and I
> accidentally type 1235, the confirm screen will catch the password mismatch
> and the passcode won't change (unless I mistype it the same way twice, which
> is rare). The system doesn't know what passcode I really want, so having the
> confirm screen is a standard way to account for human error.
>
The above is correct, and as I understood this bug — we only want the user to enter their passcode to disable/reset it once.
Flags: needinfo?(randersen)
Comment 5•9 years ago
|
||
Makes sense - moving this out of invalid then.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Updated•9 years ago
|
Component: General → Login Management
Hardware: Other → All
Comment 6•9 years ago
|
||
Added https://github.com/mozilla/firefox-ios/pull/1682/commits/cb87a5e13cbc8741e0bf13c7f02f0fdd0575c0e2 to another bug as part of the refactor work.
https://github.com/mozilla/firefox-ios/pull/1682
Comment 7•9 years ago
|
||
master cb87a5e13cbc8741e0bf13c7f02f0fdd0575c0e2
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-fxios-v4.0:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
Comment 8•9 years ago
|
||
Tested on build 4.0.0(1)
When turning passcode off the user is not prompt to 'Re-enter passcode'.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•