1252085 - Stop setting next version as a part of release tagging

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

bumps like http://hg.mozilla.org/releases/mozilla-esr38/rev/530559abe159 break uplift scripts

Comment 1

[Rail Aliiev [:rail]]

"unexpected" bump http://hg.mozilla.org/releases/mozilla-beta/rev/975faa2f4446

Comment 2

[Rail Aliiev [:rail]]

Attachment: MozReview Request: iBug 1252085 - Stop setting next version as a part of release tagging r=jlund

Review commit: https://reviewboard.mozilla.org/r/41815/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41815/

Comment 3

[Rail Aliiev [:rail]]

should file another bug to do the same for m-r

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8733569 [details]
MozReview Request: iBug 1252085 - Stop setting next version as a part of release tagging r=jlund

https://reviewboard.mozilla.org/r/41815/#review38305

iiuc the goal here is to return something callable so we end up here: https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-release.py#49 and then because the function will be a no-op, we will hit an exception during the `hg commit` but we ignore the exception: https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-release.py#92 ?

why is this an issue now for fennec? relpro mess something up?

Comment 5

[Rail Aliiev [:rail]]

(In reply to Jordan Lund (:jlund) from comment #4)
> Comment on attachment 8733569 [details]
> MozReview Request: iBug 1252085 - Stop setting next version as a part of
> release tagging r=jlund
> 
> https://reviewboard.mozilla.org/r/41815/#review38305
> 
> iiuc the goal here is to return something callable so we end up here:
> https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-
> release.py#49 and then because the function will be a no-op, we will hit an
> exception during the `hg commit` but we ignore the exception:
> https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-
> release.py#92 ?

https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-release.py#95
will ignore noop 

> why is this an issue now for fennec? relpro mess something up?

We use relpro for desktop and regular process for fennec on beta. Fennec bumps the version on relbranch and default, but the idea is to bump only by relpro on default.

Comment 6

[Jordan Lund (:jlund)]

(In reply to Rail Aliiev [:rail] from comment #5)
> (In reply to Jordan Lund (:jlund) from comment #4)
> > Comment on attachment 8733569 [details]
> > MozReview Request: iBug 1252085 - Stop setting next version as a part of
> > release tagging r=jlund
> > 
> > https://reviewboard.mozilla.org/r/41815/#review38305
> > 
> > iiuc the goal here is to return something callable so we end up here:
> > https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-
> > release.py#49 and then because the function will be a no-op, we will hit an
> > exception during the `hg commit` but we ignore the exception:
> > https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-
> > release.py#92 ?
> 
> https://dxr.mozilla.org/build-central/source/tools/scripts/release/tag-
> release.py#95
> will ignore noop 

cool, so I did understand correctly and "we ignore the exception"

> 
> > why is this an issue now for fennec? relpro mess something up?
> 
> We use relpro for desktop and regular process for fennec on beta. Fennec
> bumps the version on relbranch and default, but the idea is to bump only by
> relpro on default.

ah okay

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8733569 [details]
MozReview Request: iBug 1252085 - Stop setting next version as a part of release tagging r=jlund

https://reviewboard.mozilla.org/r/41815/#review38309

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8733569 [details]
MozReview Request: iBug 1252085 - Stop setting next version as a part of release tagging r=jlund

https://hg.mozilla.org/build/buildbot-configs/rev/8fc94db8229f