1252089 - Properly report in the crash metadata which sanitization promise we are currently blocked on

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak]]

At the moment we report which sanitizations completed, but we don't report which sanitization we are waiting.
Would be useful to know what is blocking when we abort, to direct investigations.

Comment 1

[Marco Bonardo [:mak]]

Attachment: MozReview Request: Bug 1252089 - Report the in-progress sanitization in shutdown abort metadata. r=yoric

Review commit: https://reviewboard.mozilla.org/r/37161/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37161/

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8724808 [details]
MozReview Request: Bug 1252089 - Report the in-progress sanitization in shutdown abort metadata. r=yoric

https://reviewboard.mozilla.org/r/37161/#review33713

Looks good to me.
Two minor suggestions.

::: browser/base/content/sanitize.js:156
(Diff revision 1)
> -    // Name is the itemName and promise may be a promise, if the sanitization
> +    // Name is the item's name and promise may be a promise, if the sanitization

Let's take the opportunity to make this `name` and `promise` (with backquotes).

::: browser/base/content/sanitize.js:162
(Diff revision 1)
> -        // Note we need to catch errors here, otherwise Promise.all would stop
> +      let item = this.items[name];

We could take the opportunity to annotate `progress[itemName] = "started"`.

Comment 3

[Marco Bonardo [:mak]]

https://reviewboard.mozilla.org/r/37161/#review33713

> We could take the opportunity to annotate `progress[itemName] = "started"`.

in the current situation "ready" and "started" would be the same thing, cause we start all the items at the same time.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3f936e1ca0bc

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f936e1ca0bc

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8724808 [details]
MozReview Request: Bug 1252089 - Report the in-progress sanitization in shutdown abort metadata. r=yoric

Approval Request Comment
[Feature/regressing bug #]: no regression
[User impact if declined]: The current metadata we get when sanitize aborts on shutdown is not really useful to understand where we block, this should allow us to better understand the problem and see which sanitize items need intervention.
[Describe test coverage new/current, TreeHerder]: nightly
[Risks and why]: low risk, trivial code changes
[String/UUID change made/needed]: none

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8724808 [details]
MozReview Request: Bug 1252089 - Report the in-progress sanitization in shutdown abort metadata. r=yoric

Here's hoping this improves our shutdown hang/crash data for 46.

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5f887e76a098

Comment 9

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected