1252090 - ESR 38.6.1 memory leak on www.spanishdict.com

Status: RESOLVED DUPLICATE of bug 1203973

(Firefox :: General, defect)

Description

[Tilo]

Attachment: FF_esr_issueSpanishDic.png

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20160210125511

Steps to reproduce:

Open http://www.spanishdict.com with ESR 38.6.1, non  ESR works (44.0.2)
Happens on Win 8.1 64bit and Win 2012 R2, Win 2008 R2.

should memory leaks be filed with the website operator? 


Actual results:

notice rapid memory leak and short after crash. 


Expected results:

no crash.

Comment 1

[Loic]

I doubt there is something to fix if it works with FF44, because the next ESR is 45 and will be released in a few months.

Anyway, if it leaks, you need to reproduce it with a new profile and save a memory log from the page about:memory (then attach the log to the bug report).

Comment 2

[Tilo]

Hi Loic, thanks for the info. 
I did create a new profile and the issue still exist. I can't capture the "about:memory" output as FF is unresponsive and crashes. 

here the crash Details (Win 2008 R2 system):
--------------------------------------------------
AdapterDeviceID: 0x0000
AdapterSubsysID: 00000000
AdapterVendorID: 0x0000
Add-ons: %7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D:38.6.1
AvailablePageFile: 4386684928
AvailablePhysicalMemory: 899006464
AvailableVirtualMemory: 142348288
BIOS_Manufacturer: Phoenix Technologies LTD
BlockedDllList: 
BreakpadReserveAddress: 42991616
BreakpadReserveSize: 67108864
BuildID: 20160210125511
CrashTime: 1456763449
EMCheckCompatibility: true
FramePoisonBase: 00000000f0de0000
FramePoisonSize: 65536
InstallTime: 1456758617
Notes: AdapterVendorID: 0x0000, AdapterDeviceID: 0x0000, AdapterSubsysID: 00000000, AdapterDriverVersion: 
D3D11-WARP? D3D11-WARP+ D3D11 Layers? D3D11 Layers+ 
OOMAllocationSize: 1108
ProductID: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
ProductName: Firefox
ReleaseChannel: esr
SecondsSinceLastCrash: 4725
StartupTime: 1456763411
SystemMemoryUsePercentage: 86
Theme: classic/1.0
Throttleable: 1
TotalPageFile: 10634407936
TotalPhysicalMemory: 6441984000
TotalVirtualMemory: 4294836224
URL: http://www.spanishdict.com/
Vendor: Mozilla
Version: 38.6.1
Winsock_LSP: MSAFD Tcpip [TCP/IP] : 2 : 1 :  
 MSAFD Tcpip [UDP/IP] : 2 : 2 : %SystemRoot%\system32\mswsock.dll 
 MSAFD Tcpip [RAW/IP] : 2 : 3 :  
 MSAFD Tcpip [TCP/IPv6] : 2 : 1 : %SystemRoot%\system32\mswsock.dll 
 MSAFD Tcpip [UDP/IPv6] : 2 : 2 :  
 MSAFD Tcpip [RAW/IPv6] : 2 : 3 : %SystemRoot%\system32\mswsock.dll 
 RSVP TCPv6 Service Provider : 2 : 1 :  
 RSVP TCP Service Provider : 2 : 1 : %SystemRoot%\system32\mswsock.dll 
 RSVP UDPv6 Service Provider : 2 : 2 :  
 RSVP UDP Service Provider : 2 : 2 : %SystemRoot%\system32\mswsock.dll 
 VMCI sockets DGRAM : 0 : 2 : C:\Windows\system32\vsocklib.dll 
 VMCI sockets STREAM : 0 : 1 : 
useragent_locale: en-US

This report also contains technical information about the state of the application when it crashed.
--------------

Comment 3

[Loic]

Does Firefox crash just after loading the website or after 5-10 min?

If that's the second case, can you save the memody log when the RAM use is growing up, like near 1GB.

Comment 4

[Tilo]

Hi, 

takes 30seconds until crash. and while this time FF is "Not Responding" so can't do the memory log.

Comment 5

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

I've managed to reproduce this on the latest ESR build(38.6.1). Opening the provided link, freezes Firefox and after about 30 seconds it crashes with this crash id: bp-0d5526c0-a1d9-4cfe-a19e-ca9f12160303. This reproduces on Windows 8.1 x64 as well as on Windows 7 x32.

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20160210125511

This is not reproducible on the latest release(44.0.2) nor latest Nightly(47.0a1).

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160210153822

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160302030209

Considering this, I will mark this issue as New and assign the appropriate component.
If anyone considers that the component is not the right one, please change it to a more appropriate one.

Comment 6

[Loic]

As it has been fixed, no need to keep this bug open.
Fix range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c25738e63a8214a44628df16f1c406eff9d8824c&tochange=e4f18dacf879ddce2043f9dca77af3d39c968f23

Fixed by:
Boris Zbarsky — Bug 1203973 - Move <style> and <link> attribute change handling to AfterSetAttr so that it doesn't trigger for no-op attribute changes. r=smaug

The fix is in FF42+ so the only solution is to update to ESR 45 in a few weeks.