Closed
Bug 1252110
Opened 6 years ago
Closed 6 years ago
Fix and enable browser_bug400731.js for e10s
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.08 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8724758 -
Flags: review?(jaws)
Comment 1•6 years ago
|
||
Comment on attachment 8724758 [details] [diff] [review] browser_bug400731.js.diff Review of attachment 8724758 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/safebrowsing/content/test/browser_bug400731.js @@ +11,5 @@ > + > + function contentScript() { > + let listener = function () { > + removeEventListener("DOMContentLoaded", listener); > + nit, whitespace @@ +25,5 @@ > function test() { > waitForExplicitFinish(); > > + gBrowser.selectedTab = gBrowser.addTab("http://www.itisatrap.org/firefox/its-an-attack.html"); > + onDOMContentLoaded(testMalware); why don't we have to worry about the about:blank load here triggering DOMContentLoaded?
Attachment #8724758 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 2•6 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1) > > + gBrowser.selectedTab = gBrowser.addTab("http://www.itisatrap.org/firefox/its-an-attack.html"); > > + onDOMContentLoaded(testMalware); > > why don't we have to worry about the about:blank load here triggering > DOMContentLoaded? Bug 878747 fixed that.
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=80a79e33f0e2
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/317bf8362056
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7299ec2fda76
status-firefox46:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•