Closed Bug 1252110 Opened 6 years ago Closed 6 years ago

Fix and enable browser_bug400731.js for e10s

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attachment #8724758 - Flags: review?(jaws)
Comment on attachment 8724758 [details] [diff] [review]
browser_bug400731.js.diff

Review of attachment 8724758 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/safebrowsing/content/test/browser_bug400731.js
@@ +11,5 @@
> +
> +  function contentScript() {
> +    let listener = function () {
> +      removeEventListener("DOMContentLoaded", listener);
> +      

nit, whitespace

@@ +25,5 @@
>  function test() {
>    waitForExplicitFinish();
>  
> +  gBrowser.selectedTab = gBrowser.addTab("http://www.itisatrap.org/firefox/its-an-attack.html");
> +  onDOMContentLoaded(testMalware);

why don't we have to worry about the about:blank load here triggering DOMContentLoaded?
Attachment #8724758 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> > +  gBrowser.selectedTab = gBrowser.addTab("http://www.itisatrap.org/firefox/its-an-attack.html");
> > +  onDOMContentLoaded(testMalware);
> 
> why don't we have to worry about the about:blank load here triggering
> DOMContentLoaded?

Bug 878747 fixed that.
https://hg.mozilla.org/mozilla-central/rev/317bf8362056
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.