1252110 - Fix and enable browser_bug400731.js for e10s

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Dão Gottwald [:dao]]

Attachment: browser_bug400731.js.diff

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8724758 [details] [diff] [review]
browser_bug400731.js.diff

Review of attachment 8724758 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/safebrowsing/content/test/browser_bug400731.js
@@ +11,5 @@
> +
> +  function contentScript() {
> +    let listener = function () {
> +      removeEventListener("DOMContentLoaded", listener);
> +      

nit, whitespace

@@ +25,5 @@
>  function test() {
>    waitForExplicitFinish();
>  
> +  gBrowser.selectedTab = gBrowser.addTab("http://www.itisatrap.org/firefox/its-an-attack.html");
> +  onDOMContentLoaded(testMalware);

why don't we have to worry about the about:blank load here triggering DOMContentLoaded?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> > +  gBrowser.selectedTab = gBrowser.addTab("http://www.itisatrap.org/firefox/its-an-attack.html");
> > +  onDOMContentLoaded(testMalware);
> 
> why don't we have to worry about the about:blank load here triggering
> DOMContentLoaded?

Bug 878747 fixed that.

Comment 3

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80a79e33f0e2

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/317bf8362056

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/317bf8362056

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7299ec2fda76